If a theme in /sites/sitename.com/themes/ is named the same as another theme in /themes/ you may have template_c mashed

Thanks dgtlmoon, that was an oversight on my part, I'll get it committed.

Just a thought - this could also be a security issue

-1 for /sites/<sitename>/themes/templates_c
(each templates_c directory must have proper permissions - this wouldn't really be maintainable)

+1 for using .../templates_c/<themename>_<MD5>
(although a bit long)

+2 for using .../templates_c/sites/default/<themename> and .../templates_c/themes/<themename>
(/themes/smarty/templates_c/ and anything below is writable anyway)

I should have looked a bit closer at the original solution.

+2 for using .../templates_c/sites/default/<themename> and .../templates_c/themes/<themename>
(/themes/smarty/templates_c/ and anything below is writable anyway)

I don't understand your second suggestion there.

I'm inclined to do smarty/templates_c/site_name/theme_name

I dont think there are very serious security considerations so I'll wait for feedback on this before committing (and repackaging).

my two cents: compiled templates _shouldnt_ be important to the sysop or the browser, so long as they dont overlap and are tucked away somewhere, its one of those things where if its working you really dont have much reason to be looking at it

+1 for leaving it in themes/engines/smarty/templates_c/[someUUID]/

I'm inclined to do smarty/templates_c/site_name/theme_name

seems to solve this issue, too. My proposal was to add the full path to the theme after /themes/engines/smarty/templates_c, but I think the proposal of site_name/theme_name is enough to prevent garbled output. We should go for that.

Sitename?

• Do you mean domain name? What if it the site runs on a subdirectory?


• Any other wierd char's that might not like to be a path

dgtlmoon,
see http://api.drupal.org/api/4.7/function/conf_path and http://api.drupal.org/api/4.7/file/sites/default/settings.php

Yes, the name of each site is unique and based on the folder name located in /sites. With that prefix each templates_c directory will also be unique.
F.e.

• /sites/exampledomain.com with a theme in /themes/example will be compiled in /themes/engines/smarty/templates_c/exampledomain.com/example, whereas
• /sites/exampledomain.org with a theme in /sites/exampledomain.org/themes/example will be compiled in /themes/engines/smarty/templates_c/exampledomain.org/example and even
• /sites/exampledomain.com with a theme in /sites/exampledomain.com/themes/other will be compiled in /themes/engines/smarty/templates_c/exampledomain.com/other.

The only thing which would not be supported is

• /sites/exampledomain.com with a theme in /themes/example while having also
• /sites/exampledomain.com with a theme in /sites/exampledomain.com/themes/example
• which both would be compiled in /themes/engines/smarty/templates_c/exampledomain.com/example

I don't know if we should care about the latter case, too. IMHO, a notice in README.TXT or INSTALL.TXT should be enough.

Thanks for the input sun

As for the latter situtation, I considered this. It's not a problem since a single site can only be using one of the locations at a time.

Attached patch creates a Smarty compile dir in /themes/engines/smarty/templates_c/$confdir_$themedir for each site running on one Drupal installation.

I've decided to not use subdirectories because mkdir() does not support creation of subdirectories in PHP < 5 - and IMHO there shouldn't be much more needless subdirectories at this point.

Patch stills works like a breeze.

Travis, is it possible to commit this one-liner?

+1. I've tested this patch and it worked well in a multisite environment.

Committed to HEAD and DRUPAL-4-7.