By conkhead on

Okay, I confess that I am a little reluctant to post this, as I have the feeling there is some stupidly simple solution for this that I have overlooked... but I guess that's why you guys and gals are here, huh? The Problem: I have just installed the latest update of the Aggregator2 module for Drupal 4.6 (version 1.31.2.4 of aggregator2 from 2006/07/20, into Drupal 4.6.9). Unlike in previous versions, in this version the actual printing of the HTML output for the "original article" link has been made a themeable function.

....

function theme_aggregator2_link_full_article($node) {
  if (variable_get('agg2_original_links', 0)) {
    return '<a href="'. ($node->source_link ? $node->source_link : $node->link) .'" title="'. t('Read original article.') .'">'. t('original article') .'</a>';
  }
  else {
    return '<a href="'. $node->link .'" title="'. t('Read original article.') .'">'. t('original article') .'</a>';
  }
}

Well, this is not outputting onto my pages, and I can't figure out why. I am using a very slightly modified version of the bluemarine theme (I've changed some of the table colors and CSS cosmetics, but the core of it is virtually the same), and my little mind doesn't understand why this is not working.

I've tried making this into a themeable function override, which from what I understand changes the function to...

function theme('aggregator2_link_full_article', $node) {...

...but that crashed the whole output (i.e., blank page is returned).

I simply don't understand what's going on here; and I'm hoping one of you can enlighten me. I really don't want to go back to the previous module version, as this update addressed some serious bugs. Any help or illumination anyone can offer is highly appreciated; my thanks in advance --

⋅ Categories: Drupal 4.6.x

Comments

ckeo’s picture

ckeo commented

function theme('aggregator2_link_full_article', $node) {...
is wrong. the original is correct.

theme('aggregator2_link_full_article', $node) is how you call the function, so to troubleshoot... you need to find out where the function is called.

im running 4.7 and i havnt tried the new agg2 yet so otherwise i cant be of much help.

Did you try a different theme out of curiosity ?

craig.

conkhead’s picture

conkhead commented

I hadn't thought of trying another theme; thanks for the suggestion. It did not work on any of the six other PHPTemplate themes I tried. Should I conclude from this that the problem is definitely with the module? Or is there a possibility that the problem lies with the PHPTemplate engine files? I have not spent much time with this whole theming area, so it's all kinda voodoo to me how it works, how the functions are passed off to the themes.

ckeo’s picture

ckeo commented

for that module.... and make sure everything is checked that you want

administer->settings->aggregator2

Craig.

conkhead’s picture

conkhead commented

...still doesn't work.

ckeo’s picture

ckeo commented

the links show up for me... im running 4.7.3... and i have the latest version installed (i checked and i do)

craig.