After I installed Qucktags module I found that text area it is attached to is spoiled - it became to be a single line text field (with a small height), text inside changed its color, style and size.

This happened because you are using 'form-text' class in theme_quicktags_textfield() function which is inappropriate because this class was designed for single line text fields but not text areas. 'form-text' class in my theme has fixed height which spoils the text area.

I suggest you to change 'form-text' class to 'form-textarea' class. Of course, I can overload this theme function but I'm sure this is inappropriate in any case.

Thank you. I like this module. It is realy helpful and my new filtering module will use quicktags hooks to populate my own buttons. Really nice idea !

CommentFileSizeAuthor
#4 areastyle.patch727 bytesardas

Comments

Bèr Kessels’s picture

Bèr Kessels commented

I have never seen this happen, could it be a combination of your theme, or your CSS and this (indeed!) wrongly named CSS class?

It needs to be fixed, that is for sure, but I would like to know a little more about the problem, since I cannot reproduce.

ardas’s picture

ardas commented

It is very easy to reproduce. Imagine that you are making a new theme and its specific forces you to make this:

.form-text, .form-password {
	height: 1.4em;
}

Try to put it into your theme CSS file and look at textareas with quicktags. Their heights shrink to 1.4em because quicktags module changes text areas class from 'form-textarea' to 'form-text' and all styles designed for single line text fields immediately apply to text areas.

Bèr Kessels’s picture

Bèr Kessels commented

I understand what the problem is. Care to make a patch? If you don't know how to make them, I will be happy to help you learn how to make patches for Drupal.

ardas’s picture

ardas commented
StatusFileSize
new areastyle.patch727 bytes

Here is the patch for this little fix.

Bèr Kessels’s picture

Bèr Kessels commented
Status: Active » Fixed

committed, thank you. the patch did not apply for some reason, so I modified it by hand.

ardas’s picture

ardas commented

Thanks.
That's strange ... I did it using Araxis Merge 6.5

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)