Hello,

I saw you had disabled resizable feature for text area. Are there any special reasons for that ?

I think implementing one great feature at the expence of another one is not good. I did a little patch and looks like both of them work together very well. No problems in FF and IE have been detected.

This patch is attached. Please, review it and if there are no other problems I hope it can be commited to CVS.

This patch also fixes an issue I described in other post (wrong class name for tex area).

Thank you.

CommentFileSizeAuthor
grippie.patch1.14 KBardas

Comments

Bèr Kessels’s picture

Bèr Kessels commented
Status: Active » Needs review

I will commit if I get postive reviews for the following:
* ie 5, and 6
* ff
* konqueror and safari
* opera (latest)

ardas’s picture

ardas commented

Okay.
I have tested it in FireFox, IE 6, Opera 9.0 and Opera 9.1
Everything is working correctly.

I will make tests in other browsers later because we don't have them in office right now :) It will take me a little bit more time. I'll get back with results asap.

Thank you.

ardas’s picture

ardas commented

It's not working on Konqueror!
Resizable feature works but no tags are visible.

I think this patch needs review of someone who understands javascript better then me ... Actually, I don't know it at all :)

Unfortunatly, I don't have an ability to test it on Safari.

Bèr Kessels’s picture

Bèr Kessels commented

Since Konq and Safari both use the same rendering engine, we can assume that it breaks on both.

But since I use konqueror, this is the most important browser for me. Hence I will not commit this patch untill we have at least solved the Konq. issue.

Bèr Kessels’s picture

Bèr Kessels commented
Status: Needs review » Needs work
ardas’s picture

ardas commented

Looks like I've found the reason of the problem. It is jscalendar module but not my patch.
After enabling jscalendar strange problems start happen even in FireFox - some times everything is working correctly but sometimes textarea.js, autocomplete.js and collapse.js scripts are not working which is quite strange for me.

In Konqueror browser quicktags are not working when jscalendar is active and is loaded on the same page. The defect is stable and it doesn't depend on my patch (I tried with original quicktags.module).

Without jscalendar.module everything is working on Konqueror, so you can commit this patch and I think another issue should be created but I don't know yet is it an issue of quicktags or jscalendar ... may be it is function naming conflict ...

peppelorum’s picture

peppelorum commented

The resizable textarea (with the patch) works just fine under Konqueror 3.5.5

ardas’s picture

ardas commented

Well.
Will you commit the patch or it doesn't work in any other versions ?

Bèr Kessels’s picture

Bèr Kessels commented
Status: Needs work » Fixed

Commited a slightly modified patch (patch failed, due to changes that went in in the mean time) .
Thanks for the hard work!

Bèr.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)