pshahmumbai [pshahmumbai]

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.

As per http://drupal.org/cvs-application/requirements, the motivation message should be expanded to contain more details about the features of the proposed module, and it should include also a comparison with the existing solutions. In particular, what is the difference between your module, and any module that allow to create a service equivalent to tinyURL using Drupal (see http://drupal.org/project/shorturl)?

There have not been replies in the last week. I am marking this application as won't fix.

There is a Cross Site Request Forgery in the module (hide/unhide nodes).

I am wondering if there is a better way to do this? I would be worried about security of the hiding - maybe better to implement a proper node_access to REALLY hide the node and then expose it under the URL and print using node_view() ?

http://drupal.org/writing-secure-code

1.   variable_set('specialurl_node_types', array());
   
   

   Variables are not initialized when the module is installed.

2.         drupal_set_message(t("Special URL :") . " " . $node_link);
   
   

   Use t()-placeholders.

3.         $node_link = l($base_url . "/node/" . $node->nid . "/". $result->specialurl, $base_url . "/node/" . $node->nid . "/" . $result->specialurl);
   
   

   $base_url is never prefixed to the links passed to l().

4. See http://drupal.org/coding-standards to understand how a module should be written. In particular, see how constants, Drupal variables, global variables, and functions defined from the module should be named.

It's been 7 weeks without response.

The application has been already declined because 7 weeks passed without any reply.

Please read the following links as this is very important information about CVS applications.

• Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for these applications.
• Please read Migrating from CVS Applications to (Git) Full Project Applications and Applying for permission to opt into security advisory coverage on how this affects and benefits you and the application process. In short, every user has now the permissions necessary to create new projects, but they need to apply for opt into security advisory coverage. Without applying, the projects will have a warning on projects that says:
  

  This project is not covered by Drupal’s security advisory policy.