CVS edit link for leon.nk

Module name: uc_taxononmy_tax

Related discussions here: http://www.ubercart.org/issue/15097/conditionally_tax_products_based_tax...

The uc_taxes module (part of Ubercart core) allows tax rates to be assigned to product types, so that tax is only applied to certain products in the order.

This is fine in the vast majority of cases. However, sometimes the ability to be more specific about which products are taxed is required. It can also not be convenient to separate taxed/non-taxed products by product type. In these cases taxonomy terms are more useful. (For example, in the store I am building there is a product type of Book. Uk tax laws say that books are exempt from tax, however exercise books are sometimes applicable to tax).

The uc_taxonomy_tax module works using a hook_form_alter, which allows users to select taxonomy terms to attach to a tax rate created by uc_taxes. The hook_calculate_tax() is then used to compare the products in the order with the taxonomy terms, and apply tax where needed.

There is a module that does this for the ecommerce package, but nothing at the moment for Ubercart.

About me....

I have been developing using PHP for around 3 years, and have been using Drupal for almost 1 year.
I fully appreciate the responsibility of being a module maintainer, as well as a CVS account holder. I understand the practices of good coding standards and working in a team of developers.
I am passionate about developing for Drupal and being part of this excellent community.

Thank you

Comments

leon kessler’s picture

Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new5 KB

module attached...

avpaderno’s picture

Issue tags: +Module review

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.

leon kessler’s picture

StatusFileSize
new5 KB

Thanks,

A bug has been reported since requesting the CVS account, so I'm attaching a new version with a fix.

leon kessler’s picture

StatusFileSize
new5 KB

Made a small error of not renaming constants on the last upload. Final one now...

qasimzee’s picture

qasimzee’s picture

Status: Needs review » Needs work
leon kessler’s picture

Status: Needs work » Needs review

The two modules you mentioned are quite different from this one.

The purpose of both of those modules is to apply tax on specific addresses, whereas my module's purpose is to apply tax on certain products (those with associated taxonomy terms, which neither of the posted modules takes into account).

Thanks
Leon

avpaderno’s picture

The other difference is the web service used by the existing projects; I didn't check the proposed code, yet, but I am sure it doesn't use neither the web services.

qasimzee’s picture

@kiamlaluno: So its a good candidate to be added to drupal's repository?

avpaderno’s picture

It could be a candidate for the Drupal.org repository. As the proposed module uses a different web service, it cannot be considered a duplicate of the existing project; I also think it doesn't make sense to merge the code of all the three modules in one module.

leon kessler’s picture

StatusFileSize
new5.12 KB

New version attached with a few improvements.

A big thanks to anyone who gets a chance to review this module.

leon kessler’s picture

StatusFileSize
new5.16 KB

Latest version attached...

leon kessler’s picture

Status: Needs review » Closed (fixed)

Project has now been posted by pcambra http://drupal.org/project/uc_taxonomy_tax

My request to be co-maintainer is here http://drupal.org/node/860644

Thanks

leon kessler’s picture

Status: Closed (fixed) » Needs review

Oh actually, re-opening this as not allowed to make a separate CVS account request.

So basically, changing my application to be a module co-maintainer. The module and issue request are as per the post above.

Thanks

Leon

avpaderno’s picture

Status: Needs review » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)
Issue tags: -Module review

Automatically closed -- issue fixed for 2 weeks with no activity.

avpaderno’s picture

Component: Miscellaneous » co-maintainer application
Assigned: Unassigned » avpaderno
Issue summary: View changes