In D7 there is now a hook_field_delete().

The existing function profile_field_delete() in profile.module has nothing to do with this hook, in spite of the name.

That seems confusing, although it probably won't cause any problems because I think hook_field_delete() is only invoked on the module that defines a field. But maybe the function name in profile.module should be changed?

CommentFileSizeAuthor
#1 789738-2.patch1.18 KBnaxoc

Comments

naxoc’s picture

naxoc commented
Status: Active » Needs review
StatusFileSize
new 789738-2.patch1.18 KB

I agree - that is confusing. I renamed the menu callback to profile_field_delete_field() while it is certainly less confusing is it a good name?

Status: Needs review » Needs work

The last submitted patch, 789738-2.patch, failed testing.

Status: Needs work » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.