After updating to the latest CVS version of location.module, I haven't been able to save the Province selection that I've made, even though every other value is saved properly. I looked in my MySQL database and the province simply isn't being updated. I looked through the most recent commits and couldn't find anything that would seem to affect this.
Just to note, the verification step seems to be working because if I try to use an American state with another country, it displays the proper error message. Nothing is being saved to the database however.
Can anyone else verify this problem in the current CVS? Any suggestions? Thanks!
Comments
Comment #1
solutiondrop commentedDavid,
Yes, I can verify this. I was using 4.7.3 with the most recent Location module. For what it's worth I went back to version 1.62.2.1 (4.7), as that was the last known version to work on another site I'm devloping. The Province did save correctly using the older version, before the geocoding addition.
DS
Comment #2
werdnativ commentedI've tried latest CVS (v 1.66 2006/08/12 13:23:20 ankur)
and the released 4.7 (v 1.62.2.4 2006/08/12 13:22:05 ankur)
Both of these commits have the bug. The fix is to remove a call to
$node->location = location_form2api($node->location);on line 798 of location.module. A patch against the CVS version listed above is attached. (I hope this is the right diff format... I'm using diff -u)Comment #3
David Thompson commentedThanks, that worked great! I didn't try the patch - just edited by hand.
Comment #4
mcurry commentedI just downloaded the 4.7.0 and CVS tarballs today (9/1/06); it appears that this problem is in the current sources (location.module 1.67).
Any plans for rolling this patch (or some other fix) into the official builds? Seems like this one was missed. Or is there another, 'official' fix?
Comment #5
jboeger commentedThis fixed province sticking to the database (thanks for that!) but provinces still not showing in views. I'm on 4.7.2.
Comment #6
mcurry commentedIsn't this fixed in http://drupal.org/cvs?commit=39907 and http://drupal.org/cvs?commit=39906, or have I misread the description of those changes?
Those changes appear to implement the patch mentioned above.
Comment #7
mcurry commentedThose recent changes are in the 4.7 and cvs branches - so either tarball should have these fixes, if I'm not mistaken.
Comment #8
gregglesI just confirmed that this is fixed. So I'm changing the status.
Comment #9
(not verified) commented