Product tokens not available for stock threshold mail

This issue obtains on dev-version, too.

Here's a patch.

Since uc_product_token_values() needs a full node-object you have to load the products node at uc_stock_decrement_product_stock().
uc_product will then replace [model] and all other product-tokens with their values.

Mostly [model] will be replaced with the expected value. If not you can use [stock-model] if you want to get the sold products model.

Sometime there may be situations where both is not the value you want to mail in the threshold mail or save at the order comments.
Just imagine you sell tickets for a concert with two price categorys "adults" and "children". They will share the same stock of course (maybe even on n days => n stocks). This could be managed of a custom module which should have the chance to hook into and rename the model or change other properties. This would imho be the most abstract solution at this point.

Hmm, I've got another suggestion:

Don't introduce a new hook but don't let the information in $product get lost. So there are two alternatives:

• Create an additional token type. It would look like this:
  
  <?php
function _uc_stock_send_mail($order, $product, $stock, $node) {
  $token_filters = array('global' => NULL, 'order' => $order, 'product' => $product, 'stock' => $stock, 'node' => $node);
  // ...
}
?>
  
  "node" type contains a full node which is needed by uc_product to replace all product-tokens.
  "product" could be used to give modules a chance to introduce additional token.

  Advantage: more information available
  Disadvantage: each type fires a new hook_token_values()

• The $product information could be merged with $node information which get passed to 'node' token-type. Maybe something like this:
  
  <?php
function uc_stock_decrement_product_stock($product, $key, $order) {
  // ...
  // Should we notify?
  if (variable_get('uc_stock_threshold_notification', FALSE) && $stock->stock <= $stock->threshold) {
    $node = node_load($product->nid);
    $node->product = $product;
    _uc_stock_send_mail($order, $node, $stock);
  }
  // ...
}
?>
  
  So other modules can implement hook_token_values(), too. Since $product data is available in node-type it's possible to introduce new tokens without an extra hook invocation.

I think we should not loose any data at this point to offer more flexibility.
What do you think?

Here is updated patch based on #5 and #6. No additional features introduced/provided, just plain fix to enable product tokens in stock threshold mail. (Same could be applied to 7.x-3.x as well)

Ported and committed to 7.x in http://drupalcode.org/project/ubercart.git/commitdiff/85c1f7d

The attached patch changes the default stock notification mail to include the product title, along with a set of tests.

Ported and committed to 6.x-2.x.