Pre- and Post-import hooks, with patch

I think that adding hooks in strategic places is one of the best things we can do to extend a module, so I'm keen to put this straight in!

2 things though...

I've got to rename those hooks :
hook_taxonomy_xml_vocabulary_presave(), hook_taxonomy_xml_vocabulary_postsave()
Need the full module name in it, and nothing is gained by abbreviating to 'vocab' - core has finally eliminated that sort of variation.

And would you be able to provide a cut-down example for the API doc demonstrating why you found these hooks useful?
Dangling hooks without any examples in the wild anywhere are not likely to get used well or properly. Can you give a generally useful example implementation?

my patch - against 2-dev, because that's where I am, but not significantly different from above.

Yeah, that other hook sure should be renamed, you are right.
It's getting harder to keep all the different format libraries in line, thanks for noticing the csv one. This is why I wanted to get some test suite going :-}

committed in -dev. (doing some tidy-up)
I can't do much testing or doc until I find a test case or example of these hooks being useful really. But the concept is sound by me. I'll leave the hooks dangling for now

Thanks.
What about:

  module_invoke_all('taxonomy_xml_term_presave', $term);

and

  module_invoke_all('taxonomy_xml_term_postsave', $term);

in:

function taxonomy_xml_rdf_make_term(&$term) {

And:

  module_invoke_all('taxonomy_xml_data_preprocess', $data_wrapper);

in:

function taxonomy_xml_rdf_parse(&$data, &$vid, $url = NULL) {

?

Note that module_invoke_all() doesn't support references, so we can't modify any data.
If we need to pass the $term through reference using module_invoke_all() in PHP 5.3, you need to change it to:

  foreach (module_implements('taxonomy_xml_term_presave') as $module) {
    $function = $module . '_' . 'taxonomy_xml_term_presave';
    $function($term);
  }

See:
#353494: Remove node_invoke(), comment_invoke(), etc
http://drupal.org/node/686066#comment-2822848
http://api.drupal.org/api/function/module_invoke/6
http://api.drupal.org/api/function/module_invoke_all/6

Sorry for re-opening, but it's still related to this thread.
In attachment - modified David's patch to make it compatible with PHP 5.3 and with references.
Added as well hook_taxonomy_xml_term_postsave and hook_taxonomy_xml_data_preprocess() which was initially written by David.

Committed hunk 2 and 3 from #10 to 6.x-2.x-dev
Because they make sense. Good hooks in sensible places.

Not sure about hunk 1.
hook_taxonomy_xml_data_preprocess feels like overkill. There may be a more graceful way. Or maybe it's worth a whole new format processor if the data needs that much manipulation.
Need some solid examples of use-cases and actual API docs to proceed there. Like what is the expected data, and what is expected to happen.

http://drupal.org/cvs?commit=480614