Closed (fixed)
Project:
Quick Tabs
Version:
6.x-2.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Reporter:
Created:
6 May 2010 at 19:39 UTC
Updated:
20 Dec 2014 at 03:56 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
pasqualleI do not know how did you get this error message as the file reference is with the "includes" folder [quicktabs/includes/quicktabs.views.inc]
The file was added on April 21, please test the latest dev snapshot..
Comment #2
domesticat commentedPasqualle - I'm pretty confused as well. I read over the code and it seemed straightforward, but I've confirmed that if I
rm -rfthe quicktabs module,tar -xvfthe -dev version, and run update.php, the problem comes back immediately. I've runfind . -exec grep -q "quicktabs" '{}' \; -printin my /sites directory to find any themes or modules that contained the string 'quicktabs.'Outside of the quicktabs module directory, it's all .css files and one programmatic
theme('quicktabs', $quicktabs)call. I'm zeroing in on that line to see if it's part of the problem. If not, I'm stumped.Bewildered but still digging.
Comment #3
bendiy commentedI got this same error right after installing the module on '/admin/build/modules'. It doesn't make any sense because the 'quicktabs_views_api()' function is setup fine, just like the Date module does it.
Notice that the error reports looking for 'quicktabs.views.inc' in the modules root folder, not in the 'includes' folder.
I'm running the Dev version dated May 9th 2010.
Comment #4
bendiy commentedThe problem appears to be that you have included 'function theme_quicktabs_views_render($view, $tabs, $qtid)' in 'quicktabs.views.inc'.
Theme functions should be in the main 'quicktabs.module' file, or in a theme folder under theme.inc (/quicktabs/theme/theme.inc).
By putting it in 'quicktabs.views.inc', 'quicktabs.views.inc' is included once by 'function quicktabs_theme()' and then again by 'function quicktabs_views_api()'. This violates the purpose of 'include_once()'.
I've moved all the theme functions to '/quicktabs/theme/theme.inc' and changed 'function quicktabs_theme()' to 'file' => 'theme/theme.inc'. This fixes the error.
Sorry, I don't have time to make a patch, but I think you will get the idea.
############################
/quicktabs/theme/theme.inc file:
Remove the theme functions from 'quicktabs.views.inc' and 'admin.inc'.
Comment #5
capellicI have the same error. Would be great if these fixes could be rolled into the latest DEV version... thanks!
Comment #6
sethcohn commented+1 for this... can someone roll a patch so we can get it into the dev version?
Comment #7
sethcohn commentedbetter issue title
Comment #8
ken hawkins commentedI was getting the same errors (using a quicktab that showed a view) the fix in #4 didn't seem to help me using the latest dev release, but simply moving the quicktabs.views.inc file to the module's root did.
Obviously this isn't the right place for it to be, but the module seems to be looking for quicktabs.views.inc in the wrong place.
Comment #9
jordanmagnuson commentedSame problem, using the latest version of the module.\ (6.x-2.x-rc5). The "fix" in #8 worked for me, but obviously something wrong here. Was getting the include error message on all admin pages of my site.
Comment #10
jordanmagnuson commentedNever mind--the fix in #8 didn't work. After clearing my site's cache I get this error message with wsod:
So I removed quicktabs.views.inc from the main quicktabs directory (so back to vanilla install). Of course, now my admin pages are back to giving me this error:
And also:
Comment #11
fletch11 commented+1
Comment #12
dillonm commentedSubscribing
Comment #13
hkovacs commentedi had the same errors of file not found in quicktabs root and i tried #8 solution, but moving the file gave me the new errors of file not found in includes.
so... i copied quicktabs.views.inc file into root and includes... yes, a copy in each location... two of the same, etc... this doesnt seem right, i know...
viola! the errors went away. thanks ken.
now to test the module...
Comment #14
jordanmagnuson commentedHowie: did you try clearing your site's cache? I tried copying the file, so I had the same in each location, and it worked until I cleared my cache, at which point I got this error:
Comment #15
MattBrigade commentedI was having a very similar issue with QTs version 6.x-2.0-rc5 (just released less than two weeks ago). I managed to find a work around. I've posted my fix at http://drupal.org/node/920982 (note that I didn't post in this thread because I was using a different version of Quick Tabs than the one this issue was listed under).
The fix is much like post #8 in this thread, with a couple tweaks to the module code.
Comment #16
Andrew Gorokhovets commentedI have the same error.
Comment #18
crifi commentedI have analyzed the problem a little bit more:
1. The patch in #4 doesn't work on my system, so it's not the theme.inc problem
2. I have a debian system here with the package drupal6 (6.6-3lenny6). On this system the quicktabs module caused the include_once problem described about.
So I copied the database of the 6.6.-3lenny6 installation and moved the site files in a new 6.19 installation and made an update for the copied database. After this the include_once errors has been gone...
So for me this seems to be a problem with different drupal 6 core versions! What do you think?
Comment #19
MattBrigade commentedI also just tried upgrading my Drupal 6.15 installation to the most recent version (6.19). I can confirm that this fixes the same issue with QuickTabs (which means it probably wasn't an issue with QuickTabs itself all along).
Comment #20
bohartThis patch will solve this problem.
Comment #21
drupalusering commentedsame problem as orig poster. My problem resolved when i completely uninstalled lates DEV of views and installed stable 6x release. Quicktabs installed without errors with stable views release
Comment #22
franzLooks like a good solution. If someone that downgraded views could test this to see if it works with any version of it. Should be.
It worked under Views 2.8 (it wasn't working before).
Comment #23
franzbohart, there is something wrong with the patch, I couldn't cleanly apply it (had to do it manually)
Comment #24
nancydruWorked on Drupal 6.11 and Views 6.x-2.11.
Comment #25
netw3rker commented