nickvandervreken [nickvandervreken]

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.

As per http://drupal.org/cvs-application/requirements, the motivation message should be expanded to contain more details about the features of the proposed module, and it should include also a comparison with the existing solutions.

There have not been replies in more than a week.

The ClickTale module offers support for the ClickTale tracking engine (www.clicktale.net).
It allows the user to create different configurations and blacklist/whitelist pages, ip-addresses and ranges.
Pages and IP-ranges can be specified using a regex to allow the user to match a range of IP addresses or pages with the same parent with one rule.

The description doesn't explain why the user should use the module. Saying that the module allows different configurations, and blacklist/whitelist pages doesn't say much about its purpose.

There have not been replies in more than a week. I am marking this report as won't fix.

http://drupal.org/project/issues/subscribe-mail/cvsapplications.

I would love to see this get an official project, and release.

I'm having trouble getting it to record properly. Well, actually it is recording and playing back, minus any graphics - I get a white screen with a PHP error, stating that the request came from an unauthorized IP.

Ands in my logs I get this error:
Request from unauthorized ip: 75.125.82.84, user agent: ClickTale bot.

I have not configured any blacklist IP addresses, so I'm unsure why access from the Clicktale bot is being denied. Any ideas?

Config.php already has the following:

$config['AllowedAddresses'] = '75.125.82.64/26,81.247.104.171,75.125.82.80';

75.125.82.64/26 is already in there.

I got around this for now by disabling this in ClickTaleCache.php

/* TKP - comment this out as it does not appear to be working
if ($token != "CacheTest" && ClickTale_IsAllowedIp() == false)
{
	$message = "Request from unauthorized ip: ".$_SERVER["REMOTE_ADDR"].", user agent: ".$_SERVER["HTTP_USER_AGENT"].".";
	ClickTale_Logger::Write($message);
	header("HTTP/1.0 404 ".$message);
	die ("Request from unauthorized ip.<br />IP: $_SERVER[REMOTE_ADDR]<br />$token");
}
*/

Obviously this is no good as it disables the ability to use the IP black/whitelist feature, but ClickTale_IsAllowedIp() seems to return False all the time.

Got it. Thanks.

Question for you... Have you ever managed to get Clicktale working on a site that is protected by HTTP basic authentication? Any pointers?

• The points reported in this review are not in order or importance / relevance.
• Most of the times I report the code that present an issue. In such cases, the same error can be present in other parts of the code; the fact I don't report the same issue more than once doesn't mean the same issue is not present in different places.
• Not all the reported points are application blockers; some of the points I report are simple suggestions to who applies for a CVS account. For a list of what is considered a blocker for the application approval, see CVS applications review, what to expect. Keep in mind the list is still under construction, and can be changed to adapt it to what has been found out during code review, or to make the list clearer to who applies for a CVS account.

1. Code available from third-party sites should not be committed in drupal.org repository.

2. <div id="ClickTaleDiv" style="display: none;"></div>
   <script type="text/javascript">
   if(document.location.protocol!='https:')
     document.write(unescape("%3Cscript src='http://s.clicktale.net/WRb.js' type='text/javascript'%3E%3C/script%3E"));
   </script>
   <script type="text/javascript">
   ClickTaleFetchFrom="%FetchFromUrl%";
   if(typeof ClickTale=='function') ClickTale($$$CLICKTALE_ID$$$,$$$CLICKTALE_RATIO$$$,$$$CLICKTALE_PARTITION$$$);
   </script>
   

   The content of clicktale-bottom.js is not JavaScript code.

3. The version line in the .info file needs to be removed.

4. 	$clicktale_path = drupal_get_path('module', 'clicktale');
   	$files_path = realpath(file_directory_path()) . '/clicktale';
   	$lib_path = realpath('sites/all/libraries');
   

   Is there a reason to use realpath()?

5. 			${strtolower($dir) . '_status'} = 'permissions';
   		}
   		else {
   			${strtolower($dir) . '_status'} = 'ok';
   
   

   See http://drupal.org/coding-standards to understand how a module should be written. In particular, see how the code should be formatted, and which Unicode functions modules should use.

6. require_once('clicktale.configurations.inc');
   

   There is a Drupal function to use in these cases; the reported require_once() instruction is trying to load the file from the wrong directory.
   It is not a good idea to unconditionally load a PHP file; it's better to load it when it's really required, or to merge it with the module file.

7.   $items['admin/settings/clicktale'] = array(
       'title' => 'Clicktale',
       'description' => t('Settings for the use of Clicktale tracking service.'),
       'page callback' => 'drupal_get_form',
       'page arguments' => array('clicktale_admin_settings_form'),
       'access arguments' => array('administer clicktale'),
       'file' => 'clicktale.admin.inc',
       'type' => MENU_NORMAL_ITEM, 
     );
   

   Menu descriptions and titles are not passed to t().

8. variable_get('ClickTale_PHP_Kit', '')
   

   Drupal variable names should match the regular expression /[a-z][a-z0-9_]+/.

9. The module doesn't implement hook_uninstall() to remove the Drupal variables it defines.
10. The third-party library used by the module requires PHP5, but the module doesn't declare its dependency from that PHP version (Drupal 6 is still compatible with PHP4).

Please note, to successfully use this module you might need to upgrade the PHP integration module files that come with the Drupal module with those of the latest PHP IM version. You can download the latest PHP IM files from here: http://www.clicktale.com/integration/ClickTalePHPIntegrationModule_lates....

Please read the following links as this is very important information about CVS applications.

• Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for these applications.
• Please read Migrating from CVS Applications to (Git) Full Project Applications and Applying for permission to opt into security advisory coverage on how this affects and benefits you and the application process. In short, every user has now the permissions necessary to create new projects, but they need to apply for opt into security advisory coverage. Without applying, the projects will have a warning on projects that says:
  

  This project is not covered by Drupal’s security advisory policy.

Nick is leaving the company. We will try to have an other dev pick up this module and finish it for the community.

Issue 1. When I first install this module, and I try to enable the module, Drupal 6 gives me the following error:

"The directories Cache and Logs in '/sites/default/files/clicktale' are not writable, please make sure they are. (Currently using ClickTale Directories Not writable)"

However, the directories all have permissions 755. I would have thought that was sufficient? What permissions are required? Do the files within those directories have to have their permissions manually set too? Could these instructions be added to the readme or installation files?

Issue 2.
The instructions in this thread tell me I need to update the PHP Integration files that come inside the Drupal Module, howver, there are conflicting instructions about where these replacement PHP Integration files need to be installed:

a) They are installed by default in the module directory here: /sites/all/modules/clicktale/PHP Integration module 0.9

b) However, the instructions also tell me that they need to be installed in the clicktale directory - but which one - is it:
i) /sites/all/modules/clicktale/
ii) /sites/default/files/clicktale
iii) /sites/all/libraries/clicktale
iv) /sites/all/libraries/
v) /sites/all/libraries/PHP Integration module 0.9
vi) /sites/all/modules/clicktale/PHP Integration module 0.9
vii) /sites/all/modules/clicktale/PHP Integration module 0.16

Issue 3:
Why is the replacement PHP Integration Module called version 0.16, when it replacing a version 9? Surely version 0.9 is higher than version 0.16?

Issue 4:
What do I put in the following directory as per the instructions? What directory name should I create there?
/sites/all/libraries/

Issue 5:
I got the module working when I set /sites/default/files/clicktale/Cache and /sites/default/files/clicktale/Logs to permissions 777, but now I am concerned about security and file permissions:
I have changed the permissions to ALL FILES and folders under /sites/default/files/clicktale to 764 however I am now getting mixed messages in the drupal settings page:

When I got to /admin/settings/clicktale

I get the following error message:

"The directories Cache and Logs in '/sites/default/files/clicktale' are not writable, please make sure they are." (this message is also repeated in the dlog)

HOWEVER, without doing anything, when I refresh the page the message disappears and I get the following message in the dlog "All tests OK. Good job!"

Clearly this is a bug, and I will report back when I start seeing if there are any clicktale reports available

Bumping this thread (bad I know).

In either case, I will be having to do Clicktale integration on a D6 site soon and may be able to contribute a few hours on this module. Since it's been a few months since the last post, if there has been any new developments or any further work by anyone; please update this thread, or contact me privately. I hate to see this module sit in limbo all year.

I have some site that I would like to use this project one, if nobody is making any active development or has anything against it. I can create a project page for it and continue the development and bring the module up-to-date and release ready.

subscribing ( I too am going to need this and will be putting in some time to it)

I have created a project page and rewritten most of the module code at http://drupal.org/project/clicktale, where there will be a nightly development snapshot until the code is beta ready.

I will appreciate feedback and help getting it done :-)