CVS edit link for michaeldhart

Hi! I have been building themes now for a while with Drupal, and have been building sites with Drupal since 3.8 (I think). Mostly they have been for private projects. Recently, I have been studying and applying myself to produce better-quality themes and such for potential clients as a freelancer.

This, along with a growing sense that I have benefited much from the Drupal community and contributed little, has prompted me to want to begin contributing themes to the community. So, I have my first theme ready to open to the community.

In the past I have contributed testing, and possibly a few code fixes here and there. As my PHP skills progress, I may want to contribute modules to the community. I'm looking forward to helping Drupal continue to be the great community and software I've always found it to be.

CommentFileSizeAuthor
#4 summer_city.tar_.gz135.92 KBmichaeldhart
#3 summer_city.zip138.79 KBmichaeldhart
#1 summer_city.tar_.gz732.29 KBmichaeldhart

Comments

michaeldhart’s picture

michaeldhart commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new summer_city.tar_.gz732.29 KB

Here is my proposed first contribution: a Drupal 6.x Zen subtheme called Summer City. You can see it live currently at http://www.hartfamilynyc.net

wadmiraal’s picture

wadmiraal commented
Status: Needs review » Needs work

Hi,

  1. As far as I know, you don't need to insert a LICENSE.txt file, as this will be done by the system.
  2. Your .info file could be a lot lighter (not necessary, but cleaner). Instead of :
    ; $Id

  ; The name and description of the theme used on the admin/build/themes page.
name        = Summer City
description = Three column fixed-width Zen subtheme for happy urban bloggers.

  ; The screenshot used on the admin/build/themes page.
screenshot = screenshot.png

  ; "core" specifies the version of Drupal that this theme is compatible with.
  ; "base theme" specifies that this is a theme that uses the "zen" theme as its
  ; base theme. Its unlikely you will ever need to change these, but they are
  ; required fields for a Zen sub-theme. The "engine" field is not used in a
  ; sub-theme since the engine is inherited from its base theme.
core       = 6.x
base theme = zen

    ... etc, you should just write:

    ; $Id
name        = Summer City
description = Three column fixed-width Zen subtheme for happy urban bloggers.
core       = 6.x
base theme = zen

    (You don't need to specify "sreenshot" if the name is "screenshot.png".)

  3. This is more of a question: you use a font (@font-face). Is this font GPL compatible ? Otherwise, I don't think it can be hosted on drupal.org. I think you must check this with the legal group

Otherwise, not to bad :-)

michaeldhart’s picture

michaeldhart commented
Status: Needs work » Needs review
StatusFileSize
new summer_city.zip138.79 KB

Hi Wadmiraal!

Thanks so much for taking a look for me. I've reviewed the code and made the requested changes. I was wondering about the font license myself. I did some research on it and seems there are differing opinions on what license it is released under. :) So, for the sake of keeping it legal and up to Drupal standards, I've changed the font import to one using the Google font API. There are released under Open Font License, which, as I understand it, is GPL compatible.

Attached is the updated code.

What are some next steps?

michaeldhart’s picture

michaeldhart commented
StatusFileSize
new summer_city.tar_.gz135.92 KB

Oops, here's the tar.gz

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

For files committed in Drupal.org repository, we prefer they are licensed under GPL License.

wadmiraal’s picture

wadmiraal commented
Status: Needs review » Reviewed & tested by the community

Hi all, sorry, have been really busy lately.

@kiamlaluno

The Google Font API links to an external font file, on their server. So the font is not included with the tar.gz itself (thus, not on the Drupal server).

So I guess it's ok, isn't it ? Setting it to RTBC in case it is... (I am going on vacation, so won't be able to set it before a week or 2)

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Reviewed & tested by the community » Needs work

@kiamlaluno

The Google Font API links to an external font file, on their server. So the font is not included with the tar.gz itself (thus, not on the Drupal server).

I was referring to the file border-radius.htc, which is available from third-party sites. Basing on what reported in http://www.htmlremix.com/css/curved-corner-border-radius-cross-browser, the code is developed on http://code.google.com/p/curved-corner/, where the code is reported to be GPL 3, which is then not compatible with GPL 2.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Closed (won't fix)