Closed (fixed)
Project:
Signup
Version:
5.x-2.x-dev
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
18 Aug 2006 at 10:08 UTC
Updated:
2 May 2007 at 18:18 UTC
Jump to comment: Most recent file
as i reported in http://drupal.org/node/79331 dries was giving me some suggestions about UI improvements to the signup module. one of the things he mentioned that's more of a major change is how we handle /admin/signup. currently, there are 3 tabs there for "overview" (all signups, with a confusing UI to see which are open vs. closed and operations to reopen them) "open" and "closed. dries points out that this is "incorrect use of tabs -- tabs should be actions".
i think a better UI would be something like the http://drupal.org/project/issue issue query page (sort of!). basically, a single table with columns for the things you need, and a select box to filter on either 'all', 'open' or 'closed' signup-enabled nodes. then, you wouldn't need the different tabs, some of the underlying code for the operations would be simpler (since it wouldn't have to remember what page/tab the link you're using should return to, etc.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | signup_admin_status_filter-5x-2.patch_3.txt | 3.91 KB | dww |
| #9 | signup_admin_status_filter-5x-1.patch_2.txt | 3.85 KB | dww |
| #8 | signup_admin_status_filter-5x-2.patch_2.txt | 3.91 KB | dww |
| #3 | signup_admin_status_filter-47x.patch.txt | 5.1 KB | dww |
| #2 | signup_admin_status_filter-5x-1.patch.txt | 3.04 KB | dww |
Comments
Comment #1
dwwhere's a fix for HEAD (5.x-2.*). rips out the tabs and adds a filter form (ala watchdog from core).
Comment #2
dwwbackport to DRUPAL-5 (5.x-1.*)
Comment #3
dwwbackport for DRUPAL-4-7
Comment #4
adrinux commentedCode works, but the UI has a minor issue in gecko based browsers (Firefox, Camino etc), at least in Garland, the submit button is too high compared to the . Garland's style.css adds 1em bottom margin to the .form-submit class, but sets the margin to zero on #watchdog-form-overview .form-submit.
I tried adding:
#signup-filter-status-form .form-submit { margin: 0; }
to signup.css, but on my current 5.1 test site that didn't seem to be included...maybe another bug?
Comment #5
dwwIMHO that's a bug in garland. :( i *hate* it when the theme adds this kind of cruft and then special cases it in all the places where it ends up looking bad, anyway. but alas, garland is core, and i'm sure i'd never convince anyone of my opinion on this, so screw it, i'll hack around it's "special needs"...
that said, you probably just still had your CSS compressor on when you tried to put the new thing in signup.css:
admin / site configuration / performance
turn off the compressor, clear your browser cache, reload the signup overview page, then you should be able to turn the compressor back on and everything should work.
cheers,
-derek
Comment #6
adrinux commentedI'm not going to diss garland without taking a good look at what is happening, at the end of the day not all form-submit buttons are going to be able to be styled identically - the ideal would be to create several possible classes for different interface widgets, and then all a module author would need to do is make sure they used the correct css class. Drifting off point here though...
I have the compressor off during theme development for obvious reasons, it's not on now - I just double checked. I can see 8 other style sheets including some from other modules...it really is just signup.css missing.
I've checked two different deployments of this site I'm developing and a third testing site, all on 5.1, signup.css doesn't seem to be included.
The real question is whether it's just my site with those problems or other people are seeing it. Everyone else getting signup.css ok?
Comment #7
dwwoh yeah... signup.css is only included (currently) on the node/N/edit tab, since that's the only place that the current signup.css is needed. so, you'd have to add the code to include signup.css on the page where we put this filter, if you add CSS related to the filter...
Comment #8
dwwsaw what you mean on firefox. alas. i still think that's lame behavior for garland, but whatever, i'm just the stupid module maintainer, not the mighty Designer(tm)... ;)
so, here's a new patch that includes the work-around in signup.css and includes that when viewing admin/content/signup. (HEAD/5.x-2.*) patch for DRUPAL-5 coming next, but upon further consideration, i don't think i'm going to backport this fix to 4.7.x...
Comment #9
dwwand here's the patch for DRUPAL-5
Comment #10
dwwnew patch for HEAD based on CSS suggestion from adrinux in http://drupal.org/node/32482#comment-230859 (comment #66)
Comment #11
adrinux commentedWorks as well as before and looks a little bit prettier :)
RTBC
Comment #12
dwwcommitted to HEAD and DRUPAL-5. thanks!
Comment #13
(not verified) commented