First of all, great job on that last update where you created a way for the profile form to detect when a user has uploaded an image and remind them to reupload the file when there are other form errors. Brilliant!
I found a bug in the code relating to validation of the uploaded picture when pictures are not required. When the user uploads a picture and encounters an error on different profile field, that "reminder" error is never shown. This is because the $pic_field variable is only set inside of the if {} statement, and it needs to be moved above the if/else {}. Attached is a patch that fixes this.
Someone else please review this so we can get it submitted to the next release. (It might even be a good to create another release just for this patch?)
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | reg_with_pic.patch | 1.37 KB | hargobind |
Comments
Comment #1
hargobindNot sure why the patch wasn't included after I previewed and then submitted the issue. Here it is...
Comment #2
mmilano commentedThanks, I'll get this in soon.
Comment #3
mmilano commentedfixed in version 6.x-1.7 ... thanks for the patch!