I just discovered that it is impossible to alter the menu overview tree (admin/build/menu) because it doesn't use the Forms API. Is there a specific reason why menu.module does its own stuff rather than using common APIs?

CommentFileSizeAuthor
#3 menu-forms-api_1.patch2.62 KBkkaefer
#2 menu-forms-api_0.patch2.74 KBkkaefer
#1 menu-forms-api.patch2.59 KBkkaefer

Comments

kkaefer’s picture

kkaefer commented
Assigned: Unassigned » kkaefer
Status: Active » Needs review
StatusFileSize
new menu-forms-api.patch2.59 KB

I converted the menu overview tree to forms API. It can now be altered using hook_form_alter.

kkaefer’s picture

kkaefer commented
StatusFileSize
new menu-forms-api_0.patch2.74 KB

Added documentation for theme_menu_overview_table().

kkaefer’s picture

kkaefer commented
Title: Menu overview tree doesn't use Forms API » Convert menu overview tree to Forms API
StatusFileSize
new menu-forms-api_1.patch2.62 KB

Tweaked the patch a little bit. This change is necessary to allow modules to hook into the tree.

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Postponed

i don't think we are ready yet for simple pages such as this to be rendered through fapi. there is no form here. when we have a good model for rendering entire pages though drupal_render(), then this makes sense.

feel free to reopen with reasons.

dman’s picture

dman commented

While I don't need to re-open this yet, the reason I'd like to see this is to be able to (at some point in the future) add checkboxes to each row and have a 'delete selected' button. Doing this using the many clicks currently needed is a PITA.
Granted it does need a significant rewrite to get this sort of thing happening.

I believe that taking up the 'forms in tables' patches in some way would help this to become reality.

chx’s picture

chx commented
Version: x.y.z » 6.x-dev
Status: Postponed » Fixed
Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.