Posted by dkruglyak on May 9, 2010 at 3:35am
3 followers
Jump to:
| Project: | Webform Block |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | budda |
| Status: | needs work |
Issue Summary
With weform 2.9 and latest webformblock I got a PHP error traced to webformblock, that failed to find _webform_submission_limit_check function.
The problem is within webformblock_view function that uses outdated format for loading the necessary function:
module_load_include('inc', 'webform', 'includes/webform.submissions');Updating to the format currently used by webform module fixed this problem:
module_load_include('inc', 'webform', 'webform.submissions');I marked this as "reviewed and tested" since this is a trivial one-line fix that just needs to be committed asap.
Comments
#1
Committed to CVS thanks.
#2
Oops, a minor correction in order. The argument needs to go with underscore '_', like this:
module_load_include('inc', 'webform', 'webform_submissions');Now, this has been tested and ready to commit. Sorry for the oversight.
#3
Using Webform Block with Webform 3, however, requires the original code.
I upgraded to these two:
Webform 6.x-3.0-beta5
Webform Block 6.x-1.x-dev
and got
"Fatal error: Call to undefined function _webform_submission_limit_check() in .../sites/all/modules/webformblock/webformblock.module on line 173"
The solution: changing webformblock.module line 170 back to
module_load_include('inc', 'webform', 'includes/webform.submissions');#4
I guess this module needs separate versions for separate versions of Webform.
Just to be sure Webform v3 is still in beta and v2 comes as a standard with Acquia package, so both have to be supported.