Discount on whole order

I am having the same issue. Our products are $10 each and I want to give them $10 off if they order more than 2, however if the customer order 2 + then it gives them $10 off each item in return making it FREE....

Ok, I've looked into the code on this module and here is what it is doing on the "price" discount.

LINE @ 928 -> uc_coupon.module

$result->amount = min($applicable_total, $applicable_qty * $coupon->value);

I have adjusted this to the following:

$result->amount = min($applicable_total, $coupon->value);

If this adjustment is made the "price" discount will ONLY substract the total you input in. It stops it from multiplying.
Hope this helps anyone needing it :)

I would rather see this added as another option under the conditional statement myself :) But I don't see all the places that need to be adjusted for this to work. I have copied what I am working on below:

Option under the conditional statement,
Line 924 uc_coupon module:

  if ($coupon->type == 'percentage') {
    $result->amount = $applicable_total * $coupon->value / 100;
  }
  else if ($coupon->type == 'price per qty') {
    $result->amount = min($applicable_total, $applicable_qty * $coupon->value);
  }
  else if ($coupon->type == 'price') {
    $result->amount = min($applicable_total, $coupon->value);
  }

I did add it as an option to select on the dropdown
Line 280 of uc_coupon module:

  $form['type'] = array(
    '#type' => 'select',
    '#title' => t('Discount type'),
    '#default_value' => $value->type,
    '#options' => array(
      'percentage' => 'Percentage',
      'price' => 'Price',
      'price per qty' => 'Price per QTY'
    ),
  );

This would be a nice feature to have instead of adjusting the once currently on the mod but until that is fully functional I will use the code adjust I mentioned earlier ;)

*bump* has any progress been made on this issue?

I have a client who wants to apply only ONE coupon per order. I can do the custom code, however it complicates my maintenance and I'd rather see an option built into the module itself. A simple checkbox to ask "coupon applies to each item or once per order" and then the corresponding logic in the background.

I'm not yet a module developer... is this something that is simple?

sonlinemedia,
Thanks very much for this. It's working for me. Your code should be integrated into the module almost as-is.

I say "almost" because I had to change the option value 'price per qty' which in my code became 'priceqty' -- only because the 'type' column in the uc_coupons table only holds 12 characters and 'price per qty' is 13 chars. ;)

Again, thanks. This helped me out considerably today.

If someone can provide this as a patch file against the -dev version I will commit it, this is a much-requested feature.

I was looking for this exact functionality! I modified uc_coupon.module according to sonlinemedia's post (#3 above) and it worked great. I created a patch (using sonlinemedia's code above and as longwave asked for) in hopes that this will be committed soon.

There is a bug in the patch in #7. Array key needs to be 'priceqty' instead of 'price per qty'.

Attaching a patch against dev that corrects this.

You are correct, sorry I forgot to make the appropriate change to that key. Thanks!

this worked for me as well, please commit.

The patch in #8 will break compatibility with sites that already have price coupons set up, as the behaviour of these will change. You can get around this issue now by using the coupon restrictions to limit the coupon to the one most expensive item in the cart, except in the case where your coupon value exceeds that amount.

If this is to be committed it will need an update hook in the .install file to change existing "price" type coupons to "price per qty" for coupons that don't have any restrictions.

Finally implemented this in a backwards-compatible way. In -dev you can now select whether the coupon applies to the order subtotal, all matching products, or a set of the N cheapest or most expensive matching products.

I think this needs to be another new option, rather than changing how the current option works; other users might want the existing "order subtotal" discount to only be applied if specific items are already in the cart.