Handle a relationship definition with existing types

Just a note: when writing the hook_update_N code to upgrade 2.x to 3.x, it's probably pretty safe to assume that we'll be required to add a imagefield to any existing content types already in a gallery<->image relationship. I can't think of a valid reason why someone would have duplicated the actual image in an imagefield on a node in 2.x.

There's plenty of hardcoded references to an imagefield name in the module. I knew it was wrong, I just wanted to get some POC code working. We should probably store that data in the relationship table, and make a function that uses static variable to cache the content_type->imagefield_name maps.

Also, you don't need to tag ng3 anymore, since we have a release to associate it with. Doesn't hurt, but not required :)

I just committed in a bit of code that creates some placeholders for us. I modified the schema on the relationships table to include a column named imagefield_name, and I modified it so that when asking for a relationship array, you get that field as well. I littered in a bunch of todo's with this string: '// @todo: eliminate hardcoded reference to field_node_gallery_image below' where I had hardcoded the field name in the code.

Here's some thoughts on the topic:

1) In admin.inc, when we are setting up relationships, we should present the user a select option that contains a list of all current imagefields on the image content type. If that list doesn't contain field_node_gallery_image, then we should offer that as an option as well and create it for them via the submit handler if the user selects it.

2) Regarding installation and upgrade. If the user is doing a new installation, we should just use the content copy module functionality already in the .install file to setup new content types for the user. However, using content copy on a pre-existing content type is a little iffy at times. I think that instead of using content copy on 2.x -> 3.x upgrades, we should just use our own code to add our field_node_gallery_image field to the pre-existing image content types.

I was able to get through and commit all of this except for .admin.inc and .install. There was a bug in theme.inc where you were using $node when the object was actually in $image, make sure you pull that one in.

I'll get to the rest of the patch later.

I'm just doing my due diligence and reviewing code before I commit it in. It *will* get committed in, I just need some time to review and test. I didn't commit those two files because they had the most to review, and my lunch break was about over :)

I should get them reviewed and committed tonight.

I reviewed the code - there was one bug where you were using the wrong variable name on the relationship list page that broke the link over to the imagefield page, but that's all I found. I changed a bit of the text on the admin page, it's not perfect so let me know if you don't like it.

Honestly, I'm fried and didn't get the change to test all the install stuff, but it looks pretty sound so I committed it. Thanks for all your help.

@scroogie - I'm CDT (US/Chicago). I'm on Google Talk at the email address you have for me, and I'm in #drupal most of the time too if IRC is your thing.