How about an @see between these two methods since they complementary.

CommentFileSizeAuthor
#17 common-taxonomy-D6.patch1.35 KBrdrh555
#13 common-inc-D6.patch720 bytesrdrh555
#13 taxonomy-module-D6.patch664 bytesrdrh555
#9 795022-reroll9.patch1.47 KBfmitchell
#6 795022-reroll2.patch622 bytesAnonymous (not verified)
#4 795022-reroll.patch623 bytesAnonymous (not verified)
#2 795022.patch627 bytesAnonymous (not verified)
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Title: Documentation problem with drupal_explode_tags and taxonomy_implode_tags » drupal_explode_tags and drupal_implode_tags should point to each other; taxonomy_implode_tags too.
Version: 6.x-dev » 7.x-dev
Issue tags: +Novice

I agree that taxonomy_implode_tags() could have an @see pointing to drupal_explode_tags() as a complement.

I'm not so sure about pointing in the other direction. The taxonomy function is taxonomy-specific -- so it is not just imploding tags, it is also checking to see if they are members of the right vocabulary.

Actually, the direct complementary function to http://api.drupal.org/api/function/drupal_explode_tags is http://api.drupal.org/api/function/drupal_implode_tags

These @see lines should be added to Drupal 7 first, then the patch can be ported to Drupal 6.

Good project for a novice doc contributor...

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Active » Needs review
FileSize
795022.patch627 bytes

Hope i got it right, i added the @see as jhodgdon suggested.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Needs work

WRONG... lol srry ;)

You can't put a newline at the end of a docblock :)
One reroll and I think this is ready.
Thnx for taking this one nenne.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Needs work » Needs review
FileSize
795022-reroll.patch623 bytes

You bastard! ;)

Hope this is what you meant! =)

Status: Needs review » Needs work

The last submitted patch, 795022-reroll.patch, failed testing.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
FileSize
795022-reroll2.patch622 bytes

New one!

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Needs work » Needs review
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Needs work

See comment #1. We need several more @see lines added that are not in this patch.

fmitchell’s picture

fmitchell CreditAttribution: fmitchell commented
Status: Needs work » Needs review
FileSize
795022-reroll9.patch1.47 KB

added other @see lines mentioned in comment #1

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Reviewed & tested by the community

Thanks, that will do it!

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Version: 7.x-dev » 6.x-dev
Status: Fixed » Patch (to be ported)

Can be ported to Drupal 6 now (originally reported against D6).

rdrh555’s picture

rdrh555 CreditAttribution: rdrh555 commented
Assigned: Unassigned » rdrh555
Status: Patch (to be ported) » Needs review
FileSize
taxonomy-module-D6.patch664 bytes
common-inc-D6.patch720 bytes

Didn't know how to create one patch:

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Needs work

Yeah, those patches need to be fixed up and put into one patch. They seem to be dependent on each other?

rdrh555’s picture

rdrh555 CreditAttribution: rdrh555 commented

I added the six lines as in #9; do I need to do something else before I combine into 1 patch?

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

No, I don't think so.

rdrh555’s picture

rdrh555 CreditAttribution: rdrh555 commented
Status: Needs work » Needs review
FileSize
common-taxonomy-D6.patch1.35 KB

Combined patch:

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Reviewed & tested by the community

Looks good, thanks!

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks.

Status: Fixed » Closed (fixed)
Issue tags: -Novice

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +Novice

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.