Hi,

I have created a patch that disables the popup box when there is only the Public and Hidden option. When the status image is now clicked, the status is immediately toggled.

When the Private option is available, the dialog box will popup as usual.

My main reason for creating this patch was to remove a step for the user. It didn't make sense for me to have a two-option dialog box. However, it makes much more sense to have a dialog box for more than two options

Please post any comments or concerns.

Thanks,

Erik

CommentFileSizeAuthor
cck_private_fields_module_ui_tweak.patch1.72 KBerik.ahlswede

Comments

erik.ahlswede’s picture

erik.ahlswede commented
Status: Patch (to be ported) » Needs review
kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented

Nice, using a toggle when there's only 2 choices makes a lot more sense and easier interface that a popup window. When there are more than 2 choices, this patch doesn't change anything.

roderik’s picture

roderik
Primary language Dutch
Location Amsterdam,NL / Budapest,HU
commented
Status: Needs review » Reviewed & tested by the community

Great. I'll use this on a production site.
(Even sidestepping the question "now why is my jQuery UI dialog not displaying like it should" alone would be worth it ;-) )

Patch works, looks good to me, and I don't see how anyone would not want this behavior. (So no need for options.) Or how it would clash with anything.
So setting RTBC.

A note: if your module lives in sites/all/modules/cck_private_fields, then for the patch to apply correctly, you need to do

cd sites/all/modules
patch -p5 < PATCHFILE
markus_petrux’s picture

markus_petrux commented
Status: Reviewed & tested by the community » Fixed

Very nice, thank you very much for the patch, and testing.

Committed to CVS:
http://drupal.org/cvs?commit=383540

It should be available as soon as the next dev snapshot is rebuilt (it happens twice a day).

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.