This patch does the following:

- Renames a function to include the media_mover_ui prefix
- Adds a functional 'remove' button to both the configuration add and edit forms
- Fixes some issues with the step class to enable better loading and functional deleting of steps

CommentFileSizeAuthor
#4 media_mover-795526-v2.patch2.07 KBchrisshattuck
#1 media_mover-795526.patch7.52 KBchrisshattuck

Comments

chrisshattuck’s picture

chrisshattuck commented
StatusFileSize
new media_mover-795526.patch7.52 KB

Patch attached

chrisshattuck’s picture

chrisshattuck commented

Note that this also includes the previous 'clone' fix.

arthurf’s picture

arthurf commented

In theory I want to accept this patch, however, the whole form building process for the add configuration form has to be rebuilt using #tree- because of this I don't want to accept the form bits of this patch until that is dealt with. From my testing thus far, I don't think it should be a huge issue to do so, but I don't want to write any more code that relies on the old way of form. Sorry to be a pain, but I want to try to get these big pieces cleaned up first.

chrisshattuck’s picture

chrisshattuck commented
StatusFileSize
new media_mover-795526-v2.patch2.07 KB

No problem, here's a patch without any of the form fixes. It:

- Adds configuration info to the media_mover_step class when cid is present
- Removes 'required' for description on configuration edit form

chrisshattuck’s picture

chrisshattuck commented
Title: v.6.2 - Patch to add functional 'remove' button » v.6.2 - Patch to add configuration data to media_mover_step->load
arthurf’s picture

arthurf commented

Applied the changes to the step class. Did not apply the UI changes as I'd like to work out the form issues there before patching the existing (wrong) code.

delykj’s picture

delykj commented
Version: 6.x-1.x-dev » 6.x-2.x-dev

Changed version.

darrick’s picture

darrick commented

This all seems to be in the current code. The only thing not proper is the renumbering of the steps. I.e. if I have step 1,2,3 and delete step 2 then I'm left with step 1,3. I.e. step 3 isn't renumbered to step 2.