Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.via chx:
if (variable_get('maintenance_helper_message_show', FALSE) && !count($_POST)) | no need for count just !_POST will do. And it should check for request method anwyays what happens to FILES
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 795570-post-check-3-D6.patch | 761 bytes | claar |
Comments
Comment #1
gregglesI don't understand the point about FILES.
Won't !$_POST throw a notice?
Comment #2
dave reidIf you want to get technical, then !empty($_POST) is the best as it doesn't have to cast an integer to a boolean like count does.
Comment #3
claar commentedUnless I'm mistaken (always a good bet), we can remove the $_POST check all-together, since we want the message to show on all pages.
If the $_POST check was just to prevent multiple messages, that's been fixed in #965154: Prevent duplicate messages.
$_POST check removed in attached patch -- my limited testing shows no negative impacts.
Comment #4
claar commentedCommitted to 6.x-2.x.