The block cache for og_vocab is currently not specified, so it's going to the default which is BLOCK_CACHE_PER_ROLE which doesn't make much sense. See #713556: Block cache for "Group notifications (Views enhanced)" for a report of this problem.

I think BLOCK_NO_CACHE makes more sense for this, unless you feel it is really expensive to calculate in which case we could try to do per page per user.

CommentFileSizeAuthor
#2 795916_og_vocab_cache.patch607 bytesgreggles

Comments

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented

Indeed, I think no cache should be defined, can you roll a patch?

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Active » Needs review
StatusFileSize
new 795916_og_vocab_cache.patch607 bytes

Sure.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Status: Needs review » Fixed

Committed, thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Closed (fixed) » Active

I just ran update blocks set cache = -1 where module = 'og_vocab' so the change is actually reflected in the database.

I think a hook_update could do this.

christefano’s picture

christefano commented

Looks good to me so far. Thanks!

#904678: other groups' "group categories" blocks randomly appear in my group is a duplicate of this issue.