Closed (fixed)
Project:
DFP Small Business (Google Ad Manager)
Version:
6.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
11 May 2010 at 14:58 UTC
Updated:
19 Aug 2010 at 07:00 UTC
Jump to comment: Most recent file
Comments
Comment #1
jcisio commentedSubtheme is not a problem in general. Check if there is
print $scripts;in the theme?Comment #2
frank pfabiganyes, this line "print $scripts" is there and works. other javascripts are included and show up in the source code.
i didn't mention it, but of course i flushed caches everytime.
i still haven't found out why google-ad-manager doesn't work on this specific site. meanwhile i added the gam-code manually. as we are rolling out a content-ad-network for approx. 100 websites, i will try to solve it with google-ad-manager module and will report back if i have news under which circumstances it doesn't work...
Comment #3
jcisio commentedHave you found anything new?
Comment #4
joeshock commentedI'm having the same issue. Using a subtheme, my issue is that the instructions say to place specific code in template.php, however with my subtheme I have multiple themes enabled and working from eachother and there is a template.php file in each theme folder. I tried placing the code in each of these individually and no dice. The error I get when I view the Firebug Error Console is:
Error: GA_googleFillSlot is not defined
Basically somewhere the call to add the JavaScript to the scripts variable in the page is not happening. Checked all of my page.tpl.php's and the scripts variable is definitely being output.
I'm beginning to think I might have to hard-code this into the page template maybe if it works. I would rather not have to though.
-joeshock
Comment #5
jcisio commentedMove to the latest 6.x branch. And this issue only is related to a few subthemes.
Since the version coming december 2009 you don't have to add any code into your template. I think your theme filters or overrides the "scripts" variable.
May I have a copy of your theme? Maybe only two files template.php and page.tpl.php is enough.
Comment #6
joeshock commentedI'll get you some info ASAP. Thanks for the quick response jcisio.
Just a quick note and I apologize for not having this correct before.
The version of the module I have is 6.x-1.0 not the dev version. Zip file attached with original template structure and requested files. My active theme is the one labeled _custom per the subtheming instructions provided with this template. Here is the theme I'm using. http://www.facesinthenews.com built by http://www.cmsquickstart.com
See attached. Thanks again.
-joeshock
Comment #7
jcisio commentedThe OP said about issue in dev version in May 2010, which doesn't need to manually insert code. What you are saying is a separate issue, I think you should open a new one. However, since the instruction for 1.0 is no longer valid for new version, no fix will happen in any new version.
I suggest you trying the new version in this mean time. I'll look at your theme, but only with 2.x (changes only happen in this branch).
Comment #8
jcisio commentedTo clarify the question you asked in PM: the 2.x branch is considered stable, you should test it. Now there is no known critical issue, and I'm planning for an official 2.0 release soon (#870160: Planning for 2.0 update). That's why I asked you to try 2.x branch.
Comment #9
joeshock commentedAwesome! I will give it a go and let you know how it performs. Thanks again for all the quick feedback!
-joeshock
Comment #10
joeshock commentedWorked like a charm jcisio! Great feedback and results. Thanks again for the quick response. The 2.x branch is working great for me so far!
-joeshock
Comment #11
jcisio commentedGlad to hear it.
Marking this as fixed then. Has seoscout or anyone this problem, feel free to reopen it.