splash112 [splash112]

Hello, and thanks for applying for a CVS account. I am adding the review tags, and some volunteers will review your code, pointing out what needs to be changed.

As per http://drupal.org/cvs-application/requirements, the motivation message should be expanded to contain more details about the features of the proposed module, and it should include also a comparison with the existing solutions.

Thanks for the explanation.

Hi spalash112,
I have similar requirement for one of the NGO I am working for. I was browsing through source code. and I want to know if "acl_hierarchical_perms_userreference" is not set (no user reference field) will the acl_hierarchical_perms.module work? And if we are not using nodereference field where we are are setting "acl_hierarchical_perms_userreference".
Thanks
Nikhil

Sounds interesting. Has there been any further development on this?

Right now, I have a Taxonomy for Business Units which is hierarchical. Will be nice if both can be linked together. Do you already do somthing similar?

• The points reported in this review are not in order or importance / relevance.
• Most of the times I report the code that present an issue. In such cases, the same error can be present in other parts of the code; the fact I don't report the same issue more than once doesn't mean the same issue is not present in different places.
• Not all the reported points are application blockers; some of the points I report are simple suggestions to who applies for a CVS account. For a list of what is considered a blocker for the application approval, see CVS applications review, what to expect. Keep in mind the list is still under construction, and can be changed to adapt it to what has been found out during code review, or to make the list clearer to who applies for a CVS account.

1. t() is available when hook_install(), or hook_uninstall() are invoked. See the code executed from <a href="http://api.drupal.org/api/function/php_install/6">php_install()</a> as example.
2. Hook implementation comments should be like the following one:

   /**
    * Implements hook_menu().
    */
   

   Comments for other functions should be like the following one:

   /**
    * Returns an array of related terms of the user_as_term user ID. 
    */
   

3.         $form['identification']['name']['#description'] = t('Please change username to change term name');
   
   

   Descriptions should be sentences ending with a period.