Popups could use more fine grained settings. The ability to disable popups completely in the settings would be good.

Also choosing to not use popups and set to automatically unlock when leaving edit mode by any means. It is a little too "in your face" with the constant popups. This might be good for certain instances but it is the content locking behavior that is of primary importance and the popups have nothing to do with this. For more competent users they are just a bit much and become more annoying than helpful.

If user A goes into edit mode and the node is locked then there really isn't a reason for user A to know that leaving the edit mode will automatically unlock or that he will lose all changes. Normal editing users should already know that leaving edit mode without saving will lose all changes, this again has nothing to do with content locking per se. All that really needs to happen is that when User B tries to edit HE gets the message that it is locked. User A doesn't need to be bothered with an additional step (if he choses to cancel).

This goes along with not needing a cancel button which is already an option.

Comments

eugenmayer’s picture

eugenmayer commented

Well it seems like you dont need this module. Kind of all functionalities which make this module worth a installation are not useful for you.

The popupsystem will be possible to disabled, most of the other things are by design.

Please dont create an feature request for ~5 different.

Thanks for the feedback.

endiku’s picture

endiku commented

You might want to take a deep breath and learn how to deal with constructive criticism better. Only trying to help give feedback on a good module.

eugenmayer’s picture

eugenmayer commented

All i was telling you is, you have a very technical view on this module. But he users editing are not always technical ones, so they need other messages like you would expect.

Iam referencing on

Normal editing users should already know that leaving edit mode without saving will lose all changes

or

For more competent users they are just a bit much and become more annoying than helpful.

And my result was, if you are that technical you dont need this module at all, because "you know what happens if you edit at the same time". Or lets say you dont need most parts of the module.

I did not offend you but anyhow, its up to you to read beween the lines.

endiku’s picture

endiku commented

Most drupal modules do well to focus on a specific task. What I am saying is helpful to your module, hopefully you will see that at some point.

Content locking and popup reminders of losing content without saving are not "coupled", they aren't the same thing nor are they required for one another to work. You do not need a reminder of losing work in order to know anything about the locking of content.

You might find that you know of users who find it helpful to be reminded of saving before leaving their work. That doesn't mean this module should do that. A separate "remind people not to leave without saving" module would be the best method of doing that.

eugenmayer’s picture

eugenmayer commented

I see you point @4 and thats why its a feature which will go into 1.1 with having a option for it. So no need to discuss it further .)

eugenmayer’s picture

eugenmayer commented
Status: Active » Fixed

implemented in 1.1 and will be release then

eugenmayer’s picture

eugenmayer commented

released in 6.2.0 rather then in 1.1. 1.0 will be discontinued

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.