Thanks for the work so far on this!

I just ran into an issue where some Twitter users, who haven't saved their account in a long time, have utc_offset returned as NULL. I'd suggest allowing that field to be NULL to work around the issue, then compensate for any side-effects in the code.

Comments

christoph’s picture

christoph commented

Came across this issue - actually it is where the timezone is not set on the account. The user updated the timezone in their twitter account settings and all worked fine.

craigritchie’s picture

craigritchie commented

This is also an issue on v7. I assume by the comment by christoph it's still an issue on 6.x. I'll post on v7 thread too.

michaek’s picture

michaek commented

Sounds good to me. I'll make the change for 6.x, but I'm not doing any work on 7.x for now.

juampynr’s picture

juampynr commented
Version: 6.x-3.0-beta2 » 7.x-3.x-dev
Assigned: Unassigned » juampynr
Status: Active » Fixed

Fixed for both 7.x-3.x and 6.x-3.x: Added a fallback to 0 when received value is NULL. I have reviewed the code and seen that utc_offset is not used at all so there is no risk on setting it to 0.

http://drupalcode.org/project/twitter.git/commitdiff/125cd1954ae5c727be1...
http://drupalcode.org/project/twitter.git/commitdiff/91eeb70c3302854775e...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.