Hi,

First handbook page, so a check that the language and positioning is correct would be much appreciated.

http://drupal.org/node/799494

Regards,
Anthony.

Comments

figaro’s picture

figaro commented

Looks good to me, although this sentence suggests that Drupal is internally inconsistent:
"Drupal will look for a function called 'custom_login_block' which has not been defined. "

malks’s picture

malks commented

How about if I change it to:

Drupal will not be able to find a function called 'custom_login_block' as the custom module has not yet provided an implementation of it.

figaro’s picture

figaro commented

I was wondering whether it is possible to fix the problem at the source, rather than having to propose a workaround.

malks’s picture

malks commented

I'm not sure what you mean? That it can't find the function? That's what hook_forms is for and is part of what I'm trying to show the use of.

dman’s picture

dman commented

I did a bunch of rewrite - hope you don't find the editing to vicious. :-)

- removed some of the 'talky' bits to make the language more straightforward. Lots of editing.
- added comments to the snippets, some code style repairs.
- added LOTS of cross-references to api.drupal.org and others.
- some html formatting
- hook_block uses strings as $delta these days.

... since you asked for a review, I thought it was worth a decent bit of sub-editing.

malks’s picture

malks commented

Don't mind at all dman. Looks good, thanks!

arianek’s picture

arianek commented
Status: Needs review » Fixed

just made a minor change on the formatting for the link to the api page - looks good to me otherwise, marking fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.