913 passes, 161 fails, and 87 exceptions:
- Donations: 382 passes, 0 fails, and 0 exceptions
- Paid Adverts: basics and API: 194 passes, 46 fails, and 30 exceptions
- Paid Adverts: general use case: 107 passes, 82 fails, and 39 exceptions
- Subscriptions: 129 passes, 33 fails, and 18 exceptions
- Base: basic module functionality and API: 82 passes, 0 fails, and 0 exceptions
- Base: IPN validation: 19 passes, 0 fails, and 0 exceptions

Comments

lyricnz’s picture

lyricnz commented

Starting with "Paid Adverts: basics and API" which current gets 194 passes, 46 fails, and 30 exceptions.

Many of these are caused by notices at lm_paypal/lm_paypal_paid_adverts/lm_paypal_paid_adverts.admin.inc:44

// TODO: $data[$node_type] is not always set - fix notice
$values[$subid] = $data[$node_type][$subid]->subid;

replaced with 

if (isset($data[$node_type])) {
  $values[$subid] = $data[$node_type][$subid]->subid;
}

With that change, the tests now run 194 passes, 4 fails, and 2 exceptions

lyricnz’s picture

lyricnz commented

Fixed out-of-date test text, and defined $max_length dropped during move to sub-directory.

Paid Adverts: basics and API
196 passes, 0 fails, and 0 exceptions

Next:

Paid Adverts: general use case.
107 passes, 60 fails, and 17 exceptions

lyricnz’s picture

lyricnz commented

Another instance of the wrong text being looked for, but most of the remaining issues are in subscriptions system.

Paid Adverts: general use case.
111 passes, 62 fails, and 15 exceptions

kerauno’s picture

kerauno commented

Good job on finding these!

lyricnz’s picture

lyricnz commented

Hi kerauno. I'm hoping you can fix the subscriptions issues - I don't really follow what changed. Last time I looked, some of the problems looked to be in the caching.

kerauno’s picture

kerauno commented

Ok. I'm setting up another virtual to allow me to run the simpletests cleanly.

kerauno’s picture

kerauno commented

Just did a commit. Should be available tomorrow 5/20/2010

We need to review the test scripts and see if the fails are still valid tests.

916 passes, 17 fails, and 0 exceptions

- Donations: 382 passes, 0 fails, and 0 exceptions
- Paid Adverts: basics and API: 196 passes, 0 fails, and 0 exceptions
- Paid Adverts: general use case: 107 passes, 13 fails, and 0 exceptions
- Subscriptions: 130 passes, 4 fails, and 0 exceptions
- Base: basic module functionality and API: 82 passes, 0 fails, and 0 exceptions
- Base: IPN validation: 19 passes, 0 fails, and 0 exceptions

kerauno’s picture

kerauno commented

Additional fixes and updated simpletest scripts.

Only 8 fails left. 7 are watchdog warnings related to the "signup" processor state which is not currently used and the last fail is related to a role type subscription doing admin edit.

1102 passes, 8 fails, and 0 exceptions

- Donations: 444 passes, 0 fails, and 0 exceptions
- Paid Adverts: basics and API: 245 passes, 0 fails, and 0 exceptions
- Paid Adverts: general use case: 142 passes, 5 fails, and 0 exceptions
- Subscriptions: 160 passes, 3 fails, and 0 exceptions
- Base: basic module functionality and API: 92 passes, 0 fails, and 0 exceptions
- Base: IPN validation: 19 passes, 0 fails, and 0 exceptions

lyricnz’s picture

lyricnz commented

Good work.

It appears that we have some environmental differences that are causing me to get different results to you. In particular, I'm running error_reporting=E_ALL, which warns about use of undefined variables, undefined array indexes etc. Right now, for example, I get:

Paid Adverts: general use case
115 passes, 43 fails, and 13 exceptions

I'll see if I can fix a few of those now.

kerauno’s picture

kerauno commented

hmmmm..... i've got it set to the following. I'll remove the E_NOTICE and see what the results are.

error_reporting = E_ALL & ~E_NOTICE

Yes. Additional fails with ~E_NOTICE removed.

-------------

1102 passes, 63 fails, and 35 exceptions

- Donations: 444 passes, 0 fails, and 0 exceptions
- Paid Adverts: basics and API: 245 passes, 0 fails, and 0 exceptions
- Paid Adverts: general use case: 142 passes, 38 fails, and 13 exceptions
- Subscriptions: 160 passes, 25 fails, and 22 exceptions
- Base: basic module functionality and API: 92 passes, 0 fails, and 0 exceptions
- Base: IPN validation: 19 passes, 0 fails, and 0 exceptions

------------

Let me know if you need my help.

lyricnz’s picture

lyricnz commented

Fixed a few more, got

Paid Adverts: general use case
118 passes, 11 fails, and 1 exception

Ugh, this is horrible horrible code, isn't it?

kerauno’s picture

kerauno commented

LOL. Unfortunately sometimes well written code becomes convulated as different developers apply fixes and enhancements. I've seen it for many years and I can't cast any stones since I'm not perfect either and have taken the easy way out (not often though). To me the best coding style is to create reusable objects. Then keep procedures small and clean so they are easy to read.

Let me know when you want me to jump in.

lyricnz’s picture

lyricnz commented

I'm done for the moment, I only get time for this stuff over the weekends.