Had to help Crell out with this one - the way we set up the solrconfig.xml with gettable files means that Solr will not start correctly if those files are absent - though you can have just an empty file.
We need to update the README and other docs to make a note of this for people installing.
Perhaps we should create a conf directory in CVS (or several)?
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | apachesolr-add_empty_conf_files_and_prefer_directory_copying-799970-7.patch | 4.5 KB | PatchRanger |
| #3 | 799970-README-3.patch | 724 bytes | pwolanin |
Comments
Comment #1
Crell commentedSubscribe. :-)
I'd be fine with a full "copy this directory to here and setup multicore" type setup. The book I've got on Solr basically says to not bother with non-multicore, and I needed to do multicore for my setup, so making that easy with a full drop in directory sounds fine.
Comment #2
jpmckinney commentedThis is a good argument for committing #1097976: Use ShowFileRequestHandler, gettableFiles is deprecated.
Comment #3
pwolanin commentedComment #4
pwolanin commentedcommitted to 7.x
Comment #5
pwolanin commentedcommitted to 6.x-1.x and 2.x
Comment #7
PatchRanger commentedSorry for animating old thread - but I think it is better than create new one with almost the same topic.
The problem is that I have to manually create some files, which are definitely necessary. I think it is ok in case if they were optional - but as they are really required we should include empty files in default configuration. Also README.txt has no word about
solrcore.properties, which must be copied too - so after all the proposed patch makes installation process simpler, because we avoid such problems with one-by-one copying just by copying content of the directory.Please review the patch attached. I was inspired by other efforts such as:
Comment #8
pwolanin commentedSo, I'd agree this is generally a good idea, but most people will want a non-empty stopwords file from the upstream Solr project (or elsewhere).
Also, solrcore.properties shouldn't be required. If it is, maybe there is an error in recent config file changes.
Comment #9
pwolanin commented#1984442: Make sure all values pulled from solrcore.properties have defaults, make solrconfig_extra,xml optional
Comment #10
damienmckennaMarked #1967874: Add all needed files in order to start Solr. and #1967874: Add all needed files in order to start Solr. as duplicates.
Comment #11
mac_weber commented@pwolanin I agree most people will want a non-empty stopwords file. However this is just the basic config needed to make the module run out of the box.
It takes time for beginners to realize why solr is not starting after copying the files provided by the module. Giving all files will save this pain. Everyone who wants to improve the configuration by editing the files will do it after installing and testing.
+1 for adding the empty files.
Comment #12
mac_weber commentedIt is good to be merged.
Comment #13
pwolanin commentedDoesn't look like the documentation is complete. Also, if we expect them to have an existing Solr config directory, they don't need an empty mapping file.
I'm still not convinced that this change is helpful if creating an empty file is sufficient.
Comment #14
mac_weber commented@pwolanin, do you mean adding documentation in each file explaining how they are supposed to be used later?
Comment #15
pwolanin commentedIn the READMe certainly, maybe also in each file. But if suggesting to users that copying an empty latin mapping file is the right starting point - things won't function as expected. They can just create an empty file if they somehow can't find a copy of the one that comes with Solr.