"post comments" permission does not work without "access comments"

Initially I got hung up on #438224: "Post comments without approval" permission name is completely misleading, but after enabling the wrongly-named "Post comments with approval" permission that's actually just "Post comments", this patch worked for me.

Squeezed a similar fix into #757154: Base form_id via hook_forms() not taken into account for #validate, #submit, hook_form_FORMID_alter(), this issue is a better home.

+++ modules/comment/comment.pages.inc	21 Jun 2010 18:10:38 -0000
@@ -27,79 +27,79 @@
+    elseif (user_access('access content')) {
+      $build['comment_node'] = node_view($node);

This has to invoke node_access() -- overall, that entire logic in comment_reply() scares me a bit. Did you try whether it can be simplified?

Attached is just a re-roll, including tiny adjustment of parentheses in the access condition.

40 critical left. Go review some!

Re-rolled against HEAD.

The "Add new comment" link assertion I removed in #6 is required and needs to be kept, it seems. At least, that link appears without this patch.

subscribing

Re-rolled against HEAD.

I believe this is a bug:

+    $this->assertFieldByName('comment_body[und][0][value]', '', t('Comment field found.'));

Note: [und] ;)

Well, that's not really related to this patch. Fixed it anyway.

This patch applies cleanly on the latest Drupal HEAD, does exactly what it states it will do, and has no problems found via coder. I tested this on Drupal Head on Oct. 12th, and reversed and reapplied the patch a couple times and tried posting a couple comments as well and found no issues.

Marking RTBC. Please mark back if you find an issue I didn't see.

#12: drupal.comment-permissions.12.patch queued for re-testing.

#12: drupal.comment-permissions.12.patch queued for re-testing.

#12: drupal.comment-permissions.12.patch queued for re-testing.

This is 1) a WTF and 2) a tiny API change.

#12: drupal.comment-permissions.12.patch queued for re-testing.

Sorry, but IMO this represents a behaviour change way after we can make behaviour changes like this. It's not a bad idea, mind you. But invalidates documentation and makes a miniscule API shift for a non-critical bug.

Bumping to 8.x.

Comment form on same page. 0 comments exist. View of an anonymous user, having "post comments" but not "view comments" permission:

+++ modules/comment/comment.test	7 Oct 2010 18:36:20 -0000
@@ -586,14 +587,14 @@ class CommentAnonymous extends CommentHe
+    $this->assertNoLink('Add new comment', 0, t('Link to add comment was found.'));

assertNoLink() only has two arguments. Fixed in attached patch.

Powered by Dreditor.

Although this patch can be committed as is, I wanted to mention that it has been merged into #754760: "Add new comment" appears directly above comment form / "post comments" does not work without "access comments" permission, because that patch tests all possible permutations of comment links under all possible conditions.

Let's deal with it over there.