Closed (fixed)
Project:
Corolla
Version:
7.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
16 May 2010 at 23:31 UTC
Updated:
3 Jan 2014 at 01:42 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
eigentor commentedexplanation: in the picture above both sidebars should be visible.
Comment #2
jarek foksa commentedFixed in RC6.
Comment #3
eigentor commentedSomehow Jeffs Magic appears still to have flaws :)
On the book demo page, /book my sidebar (only one sidebar there) gets pushed to faraway places:
http://screencast.com/t/MTI0ZjE0
Comment #4
Jeff Burnz commentedCan you tell me exactly what your browser is (down to version - it looks like IE6 to me) and if you are in min-width or greater, what sidebars you have enabled and blocks etc, just as much as possible, and if you were resizing the viewport when this happened.
The real surprising thing there is its LTR, not RTL! Bit odd but cant be anything major.
BTW - is that a table in the sidebar? Which block is that?
Comment #5
Jeff Burnz commentedOK, for now I isolated it to the "Recent Content" block in IE6 - does that concur with your setup?
Comment #6
Jeff Burnz commentedDammit, i see the problem - suggestion, why don't we just push a "width: expression" at IE6 and give the same layout as everything else?
I know this will get people going, but this is what they are there for, only IE6 gets it (and lets be frank, who the hell is using IE6 these days?)
Comment #7
jarek foksa commentedWe could just set fixed layout for IE6 and focus on more important issues. It's not a requirement to make the theme behave exactly the same on legacy browsers.
Comment #8
Jeff Burnz commentedOK, lets do it, better than a nasty expression, only other reliable way would be to use jQuery, but seriously we probably shouldn't bother.
Comment #9
Jeff Burnz commentedFixed with the suggestion in #7.
Comment #10
eigentor commentedSorry for not replying back ;)
Yes, it was IE6, since the title of this issue was focused on IE6, I did not mention again.
Am fine with your decision: We will get it to work finally, for now it should be good to have it fixed width.
Comment #11
eigentor commentedEr - did you check out the max with trick? Can it make it work in IE? Not giving up so quickly...
.maxwidth-960 {
max-width: 960px;
width: auto !important;
width: 960px;
}
Comment #12
Jeff Burnz commentedI dont want to give up either, I have tried that but not so much, lets keep working on it and see if we can get a CSS fix for this.
Comment #13
Jeff Burnz commentedI was able to get a min-width CSS only fix working in IE6, however it requires a shed load of extra markup to achieve.
It works by adding a border the same width as the min-width and then using negative margin to pull the content back over it.
E.g on the #page you need to add two new inner divs, i.e.
While it works (even in RTL), we'd have to add that extra markup to #navigation, #page and #footer (could use conditional comments to do so), so not so sure about this.
I dont really care about max-width for IE6, to me min-width is the one.
Comment #14
Jeff Burnz commentedProof of concept patch, this actually and works, and in limited RTL testing working in there also.
After some thought I'm not terribly worried about the extra markup, Drupal7 throws enough extra markup at us already, this is in reality a very small amount of extra markup.
Comment #15
Jeff Burnz commentedComment #16
Jeff Burnz commentedI committed this for now, if we revert later so be it, there maybe some discussion raised over id naming the the additional markup to support just one browser, at least now we have really good support cross browser rather than providing a somewhat degraded experience. I think fixing the width in IE6 was OK, but not ideal and we can do better, this fix achieves that but at a small cost (extra wrapper divs).
http://drupal.org/cvs?commit=370730
Comment #17
eigentor commentedThe issue was still there but is fixed now, as mentioned in #802894: Modify layout to support RTL and Fluid width in all browsers (except IE6).
What did I do?
I changed this
They both had 25,25% before, and this
margin-left was only 24,25% before on these.