CVS edit link for hannanxp

for now, i want to write module that i think it is needed by me and others, and i don't get it already exist on the project page
CommentFileSizeAuthor
#2 fsearch.zip8.4 KBhannanxp

Comments

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

Hello, and thanks for applying for a CVS account.

As per requirements, the proposed module must be better described, and compared with the existing solutions. The archive containing the code needs to be uploaded in a comment here.

hannanxp’s picture

hannanxp commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new fsearch.zip8.4 KB

Ok, lets start,

Some week ago, I have made sites that need to searching file content. The file it self is attached on the nodes, using upload module.

First, i looking at drupal project page, and I found the closest that i need is "Search attachments" (http://drupal.org/project/search_attachments).
But unfortunately, that module is no longer supported as it has been combined with Search Files.
So I decide to look at "Search Files" (http://drupal.org/project/search_files).

Sadly, search_files is buggy, you can see here: http://drupal.org/node/340013

So, i decide to write new module, based on search_files.

Some reason that I decide to write new module are:
1. search_files is looking all files on the server, but i just need to search attacment files. search_attachments may done for me, but as we know, there are no drupal 6.x version. the search_attachments author says that it will be submodule of search_files, but i dont get any chunk of that code that i need.

2. search_files is using cron job to examine "all" directories, and i think it take very big effort. i put it on separate process, and limited just for 'new' n files.

Ok, you can review my code here..

Thnx.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work

Thanks for your reply.

As reported from the requirements, the proposed project must not duplicate the work done in existing projects (which doesn't mean only duplicating code).

As reported in http://drupal.org/node/539608

Module 'Foo' no longer appears maintained so I have written a new version I would like to contribute. Realistically this forms duplication and Drupal.org tries to avoid this where possible (see the previous link for why this is so). The best way forward in this situation is to provide feedback to the module with patches rather than strike out afresh. If the module appears abandoned and patches sit by without review of commit, use the Webmasters to ask to take over an orphaned module.

hannanxp’s picture

hannanxp commented

Ok, thanks for your suggestion

sreynen’s picture

sreynen commented

hannanxp, you should propose changes to the existing search_files module before creating a new module. #797404: Exclude attachment types seems related issue to your first point.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs work » Closed (won't fix)

There have not been replies in the past week. I am marking this application as won't fix.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Component: Miscellaneous » new project application
Issue summary: View changes

Please read the following links as this is very important information about CVS applications.

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for these applications. Please read Migrating from CVS Applications to (Git) Full Project Applications and Applying for permission to opt into security advisory coverage on how this affects and benefits you and the application process. In short, every user has now the permissions necessary to create new projects, but they need to apply for opt into security advisory coverage. Without applying, the projects will have a warning on projects that says:

This project is not covered by Drupal’s security advisory policy.