Hi,

So impressed with the Micropublisher, thank you :)

I've just discovered that when you Record an activity message when: node insert types Press Release

[realname-link] has updated [field_image-filefield-view] [activity-node-link]

and you have not added an image, the token shows (and presuming it should be blank when empty?)

see screenshot attached

Most appreciate your reply.
Lilian

CommentFileSizeAuthor
#8 screenshot3.gif6.08 KBliliplanet
#6 screenshot2.gif15.93 KBliliplanet
#2 screenshot.gif24.1 KBliliplanet

Comments

publicmind’s picture

publicmind commented
Status: Active » Postponed (maintainer needs more info)

Hi,

First, no screenshot attached. :(
Second, FBSMP has nothing to do with node type activity publisher templates. What are you trying to do?

Cheers,

liliplanet’s picture

liliplanet commented
StatusFileSize
new screenshot.gif24.1 KB

Hi publicmind

Oops, sorry you are right, this is an activity issue ..

On the screenshot see that when you do not add an image to a node the 'token' shows instead of blank ..

I will now move this issue to activity .. my apologies

publicmind’s picture

publicmind commented
Project: Facebook-style Micropublisher » FileField
Version: 6.x-1.x-dev » 6.x-3.3
Component: Code - Functionality » Code

This is most probably a CCK filefield/imagefield issue, which is providing tokens but not the values for some of them. It might be happening because the field doesn't exists on the content type you are creating so Filefield/Imagefield can not provide values for those tokens, but when you are creating the activity publisher template it doesn't know the content type you will be creating so it shows up all the tokens.

I am shifting it to Imagefield, if it does not belong there you will be probably shifted to the right queue then.

Cheers,

liliplanet’s picture

liliplanet commented

Thank you publicmind!

Actually the image does show fine on the activity ..

the problem is when I have not uploaded an image to the node, then the 'token' shows as text where I think it should then be blank.

Wishing you a fabulous day :)

troyl’s picture

troyl commented

Make sure you have clicked the option "hide display if blank/empty " in views to correct this issue..

liliplanet’s picture

liliplanet commented
StatusFileSize
new screenshot2.gif15.93 KB

Thank you troyl!

Activity message in the view is now 'Hide if empty', but still the token shows ..

see screenshot, the first article does not have an image so shows the token, but second article does have an image .. and it's good :)

I've got a feeling this has to do with 'Activity Publisher templates'.

Record an activity message when: node update types Press Release

[realname-link] has updated [field_image-filefield-view] [activity-node-link]

Any suggestions most appreciated :)

troyl’s picture

troyl commented

Have you created a new node. to see if it works, because unfortunately for activity the messages are saved as hardcore, that means, if you change any value they will not be reflected in the previous messages....
I will try to check this and get back to you soon..

liliplanet’s picture

liliplanet commented
StatusFileSize
new screenshot3.gif6.08 KB

Thank you so much troyl !

I've tried adding a new node (press release) without image, and still the same ..

see screenshot

Beyond appreciation for your kind help :)

troyl’s picture

troyl commented

I can not say which is causing this issue however, I can say yes this is issue is happening on my end too...

I think it has to do more with how tokens are handled and output, because if you don't have data to process as a token the data is output as plain text.

You can try by adding a default picture to your content type just to reproduce it, and you will see if you don't upload a picture your shall have a default picture in it because the
token value is file tag.

[field_grouplogo-filefield-view] Fully formatted HTML file tag

Meanwhile you can trying adding picture through view directly....that way if you don't have a picture atleast the display is hidden and remove this tag.

liliplanet’s picture

liliplanet commented

Thank you troyl,

Yes I can confirm, if you add a default picture to the content type, it works, but then of course also shows up on all my content teasers (and not pretty).

(unless just maybe I am able to css the default picture as a 1x1px image, is that possible for only one content type perhaps?)

In the meantime will try as you suggest to add a picture through views .. will revert with results.

Thank you so so much troyl :)

Scott Reynolds’s picture

Scott Reynolds commented

The token needs to return an empty string '' when the field isn't present and there isn't a default image. Token will then just replace the [TOKEN-HERE] with nothing.

Should be really simple.

troyl’s picture

troyl commented

I think there should be a some sort of validation, for [token-here] to validate before being displayed to see if the data or associated field is being populated before being redered, and if it does not have anything associated with it then

It should just return nothing not the default value

something like


if !empty [value]

return ' '
liliplanet’s picture

liliplanet commented

sorry, wish I could help, this is above my head here .. :)

quicksketch’s picture

quicksketch
he/him
commented
Status: Postponed (maintainer needs more info) » Closed (fixed)

Closing after lack of activity.