Posted by NancyDru on May 18, 2010 at 4:36pm
3 followers
| Project: | Comment notify |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | NancyDru |
| Status: | needs work |
Issue Summary
Repeating all those lists and re-evaluating the values is a bit wasteful.
This patch reduces the lists and evaluations. This is a step towards #273112: Provide realname support in the existing token system.
Comments
#1
Oh, at no extra cost this week only, this also adds RealName support for the node author's name.
#2
It seems that you forgot the patch?
#3
Well, picky, picky. ;-)
#4
It is, of course, for 6.x. I will see if I can get everything on 7.x soon.
#5
The last submitted patch, comment_notify.list_reduce.patch, failed testing.
#6
This seems pretty handy.
I think that the '!edit_uri' value will need to be generated on each loop, right? Which is what you are doing with '!link1' value, right?
#7
Probably does, so I need to fix that...