Repeating all those lists and re-evaluating the values is a bit wasteful.

This patch reduces the lists and evaluations. This is a step towards #273112: Provide realname support in the existing token system.

CommentFileSizeAuthor
#3 comment_notify.list_reduce.patch10.65 KBnancydru

Comments

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

Oh, at no extra cost this week only, this also adds RealName support for the node author's name.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

It seems that you forgot the patch?

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
StatusFileSize
new comment_notify.list_reduce.patch10.65 KB

Well, picky, picky. ;-)

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

It is, of course, for 6.x. I will see if I can get everything on 7.x soon.

Status: Needs review » Needs work

The last submitted patch, comment_notify.list_reduce.patch, failed testing.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

This seems pretty handy.

I think that the '!edit_uri' value will need to be generated on each loop, right? Which is what you are doing with '!link1' value, right?

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

Probably does, so I need to fix that...