Siteminder doesn't clean up the siteminder table

if a user comes to the site & their account is created via siteminder an entry is created in the siteminder table that maps the drupal uid to the siteminder identifier.

if a drupal admin deletes the user that was created, that entry is left in the database. Now, if that user comes back, they receive an access denied because siteminder finds the id in its list, but cant load the user.

Ultimately, this is actually a job for the authmap table which was designed specifically for the purpose of linking drupal users to external authentication systems. my suggestion is to switch to using the authmap table and let drupal clean up the data in it when the user is deleted.

initially, since switching to using the authmap table would require a reasonable rewrite of code, we simply need the following code:

function siteminder_user($op, $edit, $user){
  switch($op){
    case 'delete':
      db_query("delete from {siteminder} where uid=%d", $user->uid);
  }
}

I'll get a patch in for this later too.