vaeiou [vaeiou]

I have attached tarballs of each of the modules, md2 and og_mp for review

Thank you.

Additional information:

Organic Groups privacy integrates with Views 2. It is an additional field in Views that appears when you create/alter the Organic Groups Membership List.

mdb2 requires parameterized queries and supports prepare and execute statements.

mdb2

This module provides the means for other Drupal modules to interface with the mdb2 database library. The mdb2 package provides a common API for a number of packages. Multiple database connections to different RDBS can be established. Each database connection is defined in a file specified in the mdb2 configuration page. The database connection is defined in this manner:

var $db_info = array(
  'dbtype', // database type
  'username', // db username
  'password', // password
  'hostspec', // hostname
  'database', // db name
  'port', // database port (defaults to standard)
);

The module uses the first part of a constant defined in the password file to identify the connection. For example:

<?php
  define("test1db_DB_NAME, "test1db");
  define("test1db_DB_HOST, "localhost");
  // ...
?>

There are two methods to use the db, raw query methods and and with parameterized queries. Parameterized queries are strongly recommended.

// Raw query example:
$this->db->selectQuery("SELECT * FROM test1;";

// Parameterized query example:
  $statement = '';
  $types = array('text'); // data types
  $values = array(':name' => 'vaeiou'); // values are automatically sanitized. no need for check_plain

  $statement = "SELECT id FROM test1 WHERE name = :name ;";
  $result = $this->db->mdb2_query($statement, $types, $values);
  $names = $this->db->fetchAll($result);

  return $names;

og_mp: Organic Groups Membership Privacy

The og_mp module enhances the organic groups membership listing view to allow users to hide their membership from various roles. A table is created to store the preferences for each user/group. An OUTER JOIN is implemented in the Views API so that all users do not have to have a corresponding entry in the og_mp table.

The module makes use of hook_views_pre_execute().

function og_mp_views_pre_execute(&$view) {

  if ($view->name == 'og_members') {

  	$pattern = "/users.uid = og_mp_privacy.uid/";

  	// Correct the join that Views makes (Views can't do conditional joins)

  	$replace = "(og_mp_privacy.uid = og_uid.uid AND og_mp_privacy.gid = og_uid.nid)";



    // Alter the regulary query.

    $view->build_info['query'] = preg_replace($pattern, $replace, $view->build_info['query']);

    

    // Alter the count query.

    $view->build_info['count_query'] = preg_replace($pattern, $replace, $view->build_info['count_query']);

  }

}

The {og_mp} table structure:

/* 
 * {og_mp_privacy} table
 * +---------+------------+------+-----+---------+-------+
 * | Field   | Type       | Null | Key | Default | Extra |
 * +---------+------------+------+-----+---------+-------+
 * | uid     | int(11)    | NO   | PRI | 0       |       | 
 * | gid     | int(11)    | NO   | PRI | 0       |       | 
 * | privacy | tinyint(4) | YES  |     | NULL    |       | 
 * +---------+------------+------+-----+---------+-------+
 */

I have attached a screenshot of the Views builder screen. One simply adds the OG Membership Privacy field to the view.

If one of the modules is accepted does that mean I can add the other project as a CVS commiter?

I would like to submit the og_mp module. I have attached another screenshot of what the membership listing page looks like.

Thanks.

Thanks for your time, kiamlaluno.