Too much hand holding here, got to go.

Comments

Jeff Burnz’s picture

Jeff Burnz commented
Status: Active » Fixed

Fixed: http://drupal.org/cvs?commit=369308

eigentor’s picture

eigentor commented
Status: Fixed » Active

Still, there is need to resize Teaser and Full node images. Did you remove any resizing?
The full node image can become to wide for the content region, especially since we have fluid layout.

Jeff Burnz’s picture

Jeff Burnz commented

Maybe we should just do :

#block-system-main .content {
  overflow: hidden;
}

Setting a width on images with CSS feels way wrong to me and like nanny-hand-holding, I think theres always some configuration to do for users, we can make a documentation issue.

eigentor’s picture

eigentor commented

O.K. for Full node this is o.k.
While for teasers things are different: Core does not provide limitless Image Styles (Imagecache presets) and we need to set Teaser images fitting from core.
For Full Node I am with you.

While I can see your point... How did Bartik solve this?

Jeff Burnz’s picture

Jeff Burnz commented

Bartik doesnt try to solve it, images just overflow if two sidebars are enabled.

Core does provide unlimited Imagecache presets, just like Imagecache always has, add a new style, go to the field display settings and select the style.

eigentor’s picture

eigentor commented

Actually I had another idea: the teaser image provided by core is just too big. So who, if not the core themes, should have it in a usable size.

So how about filing a core patch to scale it to a size that accomodates both Bartik and Corolla (and sure Garland).
We need pretty teaser images out of the box. No way to advide people to learn imagecache before they can post an image.

Jeff Burnz’s picture

Jeff Burnz commented

I agree dude, post an issue, the default imagecache presets are very large indeed. I dont think either of the new themes handle these sizes very well.

Jeff Burnz’s picture

Jeff Burnz commented
Status: Active » Postponed

Lets just postpone this guys, its a core issue since it actually affects all core themes.

eigentor’s picture

eigentor commented

Filed a bug, filed a patch to reduce it to 480px width: #820020: Full node image is too large - reduce to 480px width

Jeff Burnz’s picture

Jeff Burnz commented
Issue summary: View changes
Status: Postponed » Closed (outdated)