Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Today when playing around with uploading some users, I tried to import a file named "users.csv" and forgot to give it a new table name. Bam. Goodbye Drupal users table... Seems like we should do some sanity checking on which tables we're overwriting.
I'm going to try to provide a patch, but wanted to get some input on whether or not we should have "disallowed" table names? Or just warnings and confirmations?
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 803958.patch | 1.16 KB | eporama |
Comments
Comment #1
eporama commentedFrom the "uploadhelp" element in the fieldset for uploading the delimited file, the instructions say:
This implies to me that we should only really be replacing file data if we had previously been working with the table in tw anyway.
So here's a possible patch that checks to make sure its a tw managed table before replacing the data...
Comment #2
eporama commentedwell, looks like there's not much input on this as is, so perhaps I should have set it to needs review.
Comment #3
mikeryanGood catch, I've committed it, thanks!