Closed (fixed)
Project:
Colorbox
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
20 May 2010 at 07:25 UTC
Updated:
8 Aug 2010 at 06:40 UTC
Many users seems to miss the installation instructions in the README and ends up with a broken Colorbox installation. A big part of the bug reports is caused by this.
This patch implements hook_requirements() and adds a _colorboc_status() fuction.
If the Colorbox plugin is missing or jQuery Update 6.x-2.0 is not installed the status page will report this with descriptions how to resolve it.
| Comment | File | Size | Author |
|---|---|---|---|
| colorbox_hook_requirements.patch | 4.13 KB | frjo |
Comments
Comment #1
manuel garcia commentedDefinetly +1 to this.
In Gallery Formatter issue queue im getting reports that the module doesn't work with colorbox because of people not following the installation instructions for colorbox. This ends up in a call to an undefined function in jQuery, thus breaking all JS in the site, including galleryformatter's.
I'm sure this is not the only module that gets affected, never underestimate user's hurry/lazyness/lack of experience!
I suggest we go even further and include a check on this before we load the colorbox module's JS onto the page, to avoid JS errors if the plugin is not installed on the site, and/or ad a check for
if((jQuery.fn.colorbox){ // do our magic here }. Also, if you aren't already doing it in the patch, spam the admin with error messages indicating him how to dl the plugin/update jquery.Comment #2
frjo commentedPatch committed to 6-dev so more people can test it.
Comment #3
frjo commented