Hi,
I have installed your module.
When I have create a new menu, I find that CSS ".menu-733, ul.links li.menu-733" the height is the same of image's width.
I post the patch that I have used for my website.
I hope it can be useful. :D

bye bye. .hachreak.

CommentFileSizeAuthor
menu_icons-6.x-2.4.diff1.57 KBhachreak

Comments

shadcn’s picture

shadcn commented

Good patch. Thanks

skilip’s picture

skilip commented
Status: Patch (to be ported) » Needs review
nicholas.alipaz’s picture

nicholas.alipaz commented
Status: Needs review » Reviewed & tested by the community

Works for me should be committed.

simoneg’s picture

simoneg commented

Patched it manually and it works great now. Should be committed. Thanks so much.

hwasem’s picture

hwasem commented

Thanks for the patch suggestions. I found this exact problem in version 7.x-3.0-beta3. The changes were slightly different from the patch as this is Drupal 7...

Changed menu_icons.module:
line 307 as follows:

---   $css .= theme('menu_icons_css_item', array('mlid' => $item->mlid, 'path' => $image_url, 'size' => $info['width'], 'pos' => $pos));
+++         $css .= theme('menu_icons_css_item', array('mlid' => $item->mlid, 'path' => $image_url, 'size' => $info['width'], 'height' => $info['height'], 'pos' => $pos));

line 323 as follows:

--- 'variables' => array('mlid' => NULL, 'path' => NULL, 'size' => NULL, 'pos' => NULL),
+++   'variables' => array('mlid' => NULL, 'path' => NULL, 'size' => NULL, 'height' => NULL, 'pos' => NULL),

Changed menu_icons_css_item.tpl.php:
line 23 as follows:

---          height: <?php print $size?>px;
+++       height: <?php print $height?>px;

I re-added the image to the menu and the height of the items were now displaying properly. I hope this helps someone else in the future.

hwasem’s picture

hwasem commented
Version: 6.x-2.4 » 7.x-3.0-beta3

Updating version since this is a problem in the current version as well.

xaa’s picture

xaa commented

#5 works. thanks

acrollet’s picture

acrollet commented
Title: Heigh confused with width » Height confused with width
Version: 7.x-3.0-beta3 » 6.x-2.4
Status: Reviewed & tested by the community » Patch (to be ported)

Committed in http://drupalcode.org/project/menu_icons.git/commit/a9625bc, thanks!