The CVS logs contains two commits from 22 and 23 August 2009 that references #542658: Move action "tabs" out of local tasks:

The latter commit seems unrelated to that issue. It contains a small spelling fix to system.module, and it removes some lines from default.settings.php:
cvs diff -r1.28 -r1.29 sites/default/default.settings.php

I assume the change to default.settings.php was unintended.

Two blocks of code were removed. Both had been added a few days earlier, as part of #370454: Simplify page caching and #538032: Document possible preg memory issues. This patch puts these two blocks back in.

CommentFileSizeAuthor
#11 revert-1.29-804844-11.patch1016 bytesnikunjkotecha
#4 revert-1.29-2.patch1.74 KBc960657
revert-1.29-1.patch3.06 KBc960657

Comments

c960657’s picture

c960657 commented
Status: Active » Needs review
retester2010’s picture

retester2010 commented

revert-1.29-1.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, revert-1.29-1.patch, failed testing.

c960657’s picture

c960657 commented
Status: Needs work » Needs review
StatusFileSize
new revert-1.29-2.patch1.74 KB

The pcre part was committed in #538032: Document possible preg memory issues. This is a reroll containing only the change from #370454: Simplify page caching.

thedavidmeister’s picture

thedavidmeister commented
Issue summary: View changes
Status: Needs review » Needs work
Issue tags: +Needs reroll, +Novice

indeed.

RTBC from me after a reroll.

joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented
Assigned: Unassigned » joshi.rohit100
Issue tags: +SprintWeekend2015
joshi.rohit100’s picture

joshi.rohit100
he/him
Primary language Hindi
Location Delhi, India
commented

Is this valid now ? As I am seeing totally different default.settings.php now.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Assigned: joshi.rohit100 » Unassigned

Unassigning stale issue. Hopefully someone else will pursue this.

vprocessor’s picture

vprocessor commented
Assigned: Unassigned » vprocessor
vprocessor’s picture

vprocessor commented
Assigned: vprocessor » Unassigned
nikunjkotecha’s picture

nikunjkotecha
he/him
Primary language Gujarati
Location India, Gujarat, Rajkot
commented
Status: Needs work » Needs review
Issue tags: -SprintWeekend2015
StatusFileSize
new revert-1.29-804844-11.patch1016 bytes

There is a new block added in default.settings.php now with Page cache so updated title to Page caching memcache: in rerolled patch.

Status: Needs review » Closed (outdated)

Automatically closed because Drupal 7 security and bugfix support has ended as of 5 January 2025. If the issue verifiably applies to later versions, please reopen with details and update the version.