Porting to Drupal 4.7 [#80662]

Comment	File	Size	Author
#17	fckeditor.module_0.patch	1.96 KB	havran
	fckeditor.tar.gz	14.21 KB	FredCK

Comment #1

efolia commented 25 August 2006 at 23:27

mmm... it sure doesn't work for me. Neither the popup nor the in-window versions do anything (no menu beside the ok/cancel twins, and no way to input in the popup... the in-window version doesn't do a thing). The pop-up version displays the ...popup.html file, but nothing more. I tried it under Opera, Firefox and IE. Looks like javascript doesn't kick in (I have it enabled on all my browsers, same for popups).

efolia

Log in or register to post comments

Comment #2

FredCK commented 26 August 2006 at 06:46

Have you followed the editor installation instructions as described in the README.txt? Remember that the module doesn't come with the FCKeditor scripts.

Log in or register to post comments

Comment #3

ontwerpwerk commented 26 August 2006 at 16:50

I will test it the coming week, but from the looks of it it is a very practical version of the module.

I did notice however that the module you made is licensed under the LGPL licence, which is a problem for inclusion in the repositories at drupal.org

Log in or register to post comments

Comment #4

FredCK commented 26 August 2006 at 17:06

The module itself is under the GPL. FCKeditor, which must be installed separately, is under the LGPL. The separated installation is needed (maybe?) because of the licensing differences, which doesnt bring any trouble to the end user.

Actually I think that there would be no problem on including the editor in the module too, to make its installation easier. The fact is that the LGPL gives all grants of the GPL, plus some additional things. So, there would be no incompatibility in it. There would be a problem if we would do the opposite, if I would like to distribute the module inside FCKeditor, under the LGPL, which is not the case.

Any thoughts regarding this issue are welcome, as it would make the installation process much easier (actually the module would work out of the box).

Thanks for your comments.

Best regards,
Frederico Caldeira Knabben
----
http://www.fckeditor.net
"Support Open Source Software"

Log in or register to post comments

Comment #5

fwdrupal@drupalcenter.de commented 28 August 2006 at 07:20

Hi,

it doesn't work for me too. I've tried any possible configuration but anytime it shows an error message similar to "fckeditor.popup.html not found" - no matter what basedir is configured.

And i tried all the patches posted here before too -- nothing works.

This is really bad because i like the FCKeditor much more than the tiny one...

In my opinion (i'm not a programmer) it's a problem of telling drupal where the functional parts of this module are. I suggest the problem is that i installed drupal in a subdirectory (www.domain.com/drupal instead of www.domain.com).

Bye

Log in or register to post comments

Comment #6

FredCK commented 28 August 2006 at 09:08

Can you attach the HTML of the form page? Maybe it could give some clues about the problem.

Thanks in advance.

Log in or register to post comments

Comment #7

scroogie commented 28 August 2006 at 09:24

Hey, its great to have you on board Fred, you are the original author of FCKEditor, arent you? I will be happy to test your contribution today eve. Will let you know the results then. It would be great if the FCKeditor module would be actively maintained again. Maybe we could tackle some integrations later, like input filters and image integration.

Log in or register to post comments

Comment #8

FredCK commented 28 August 2006 at 09:56

Yes, I'm the "FCK" in FCKeditor. I'm discussing with other guys about the re-launch of the FCKeditor module effort. I think we'll have wonderful results here.

Log in or register to post comments

Comment #9

scroogie commented 28 August 2006 at 14:22

Do you have some kind of Wiki-Site or something? I would like to contribute my thoughts, at least the ideas or as contrib modules.

Log in or register to post comments

Comment #10

FredCK commented 28 August 2006 at 14:51

Well... the editor development will have nothing to do with the module development. Let's say that these are two independent developments, but as I'm working on both, there would be some collaboration between then.

So, you will find nothing regarding the module in the editor site or the Wiki. We must use Drupal resources for the module discussions.

In the FCKeditor module page (http://drupal.org/project/fckeditor) I don't see any place for open discussions, but the "Support Forum" could be used for that (http://drupal.org/forum/18), or even the module maintainer could bring us some tools in this sense (specific forum or wiki). I think that any idea in this sense is welcome.

Best regards,
Frederico Caldeira Knabben
----
http://www.fckeditor.net
"Support Open Source Software"

Log in or register to post comments

Comment #11

fwdrupal@drupalcenter.de commented 28 August 2006 at 15:16

Hi Fred,

thanks for your efforts!

Here some information:
WAMP-Server: Apache 1.3.37 with mod_rewrite, PHP 4.x, MySQL 3.x, Drupal 4.7.3 no extra modules
basedir of FCKEditor module set to default: //modules/fckeditor/fckeditor/ (the extra slash not a typo! even without it it won't work)

HTML-Source:

<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN">
<HTML><HEAD>
<TITLE>404 Not Found</TITLE>
</HEAD><BODY>
<H1>Not Found</H1>
The requested URL /modules/fckeditor/fckeditor.popup.html was not found on this server.<P>
<HR>
<ADDRESS>Apache/1.3.37 Server at www.domain.com Port 80</ADDRESS>
</BODY></HTML>

At that stage it doesn't produce an error message in the watchdog...

The domain name is a forwarded frame to a subdirectory on my server at home (e.g. www.domain.com points to domain.dyndns.org/drupal)

Bye

Log in or register to post comments

Comment #12

fwdrupal@drupalcenter.de commented 28 August 2006 at 15:39

Me again.

I've tried this module with another server (www.domain2.com which is not forwarded and with drupal installation at the top directory level), changed the default basedir from //... to /... and it works at a first glance smoothly.

Maybe the problem above is my configuration of the apache (but it was fine with Drupal 4.6.x and fckeditor.module)

Bye

Log in or register to post comments

Comment #13

scroogie commented 28 August 2006 at 16:01

@fwdrupal, If the webserver cant find /modules/fckeditor/fckeditor.popup.html then you certainly misconfigured your path. You have to use the path from the perspective of the webserver. If your domain uses simple forwarding, then the /drupal prefix is still needed for your apache (that doesnt hold for vhosts). In your case it is "/fw/modules/fckeditor/fckeditor.popup.html" (because your drupal resides in the fw dir).

Log in or register to post comments

Comment #14

scroogie commented 28 August 2006 at 16:44

FredCK: If we want to collaborate we could create a group on groups.drupal.org for the development. For now I could probably use the issue tracker and submit it as feature requests.

Log in or register to post comments

Comment #15

ontwerpwerk commented 28 August 2006 at 16:45

Assigned:

Unassigned

» ontwerpwerk

I updated the HEAD/cvs with a version that uses FredCK's method of initializing the module

Some options were also added

you can disable certain textareas based on their id and on the number of rows a textarea has
Role based editor toolbars (2 toolbars to choose from)

Feel free to test it on your 4.7 install

// ssip is not tested yet

Log in or register to post comments

Comment #16

ontwerpwerk commented 28 August 2006 at 16:46

(you will probably have to wait a little until the CVS tarball is regenerated, the date should be somewhere near 28 august)

Log in or register to post comments

Comment #17

havran commented 28 August 2006 at 19:48

Status	File	Size
new	fckeditor.module_0.patch	1.96 KB

I make some small changes for Drupal wich is installed in subdirectory - using base_path() function solve this issue. Patch attached.

Log in or register to post comments

Comment #18

ontwerpwerk commented 28 August 2006 at 20:41

Priority:

Critical

» Normal

Wow, that was fast....

Please open a new issue for this kind of patches, makes it easier to track what is done
(I'll check this one tomorrow)

Log in or register to post comments

Comment #19

scroogie commented 28 August 2006 at 23:05

What exactly are you trying to do here?

-    drupal_add_js(preg_replace('/^\//', '', $base_path) . 'fckeditor.js');
+    drupal_add_js(preg_replace('/^'.str_replace('/','\/',base_path()).'/', '', $base_path) . 'fckeditor.js');

The first seems to remove a leading slash in the $base_path but the second doesnt make sense to me.

Log in or register to post comments

Comment #20

ontwerpwerk commented 29 August 2006 at 08:30

I think the removal of double slashes should be unneccesary, adding the base path might be an idea.
I'm not satisfied about all those path variables at the moment, so I'll try to improve on them the coming days.

Log in or register to post comments

Comment #21

FredCK commented 29 August 2006 at 11:15

Status:

Needs review

» Fixed

I think we can mark this task as fixed, as it has already been committed to the CVS. Otherwise we will continue discussing about it here, and we must instead open other tasks for things already in the CVS.

Please reopen it if you fill it is not the right thing.

Log in or register to post comments

Comment #22

(not verified) commented 12 September 2006 at 11:15