Closed (fixed)
Project:
Service links
Version:
6.x-2.x-dev
Component:
Code
Priority:
Critical
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
23 May 2010 at 03:00 UTC
Updated:
28 Dec 2010 at 10:25 UTC
Jump to comment: Most recent file
Comments
Comment #1
darkkin commented+1
Comment #2
TheCrow commentedI don't note this error,
where the "src" attribute point?
can you open this image directly?
could be a local trouble ...
Comment #3
darkkin commentedHi, TheCrow.
When I enable service_links "Only Image" in my custom theme then I see the same error like in post #1, but when I use other theme like Garland the error disappears. Probably problem in my custom theme?
Comment #4
TheCrow commentedso seem darkkin... your theme derive from another one? or it's write from zero?
How i can reproduce the error?
Comment #5
darkkin commentedThanks for your answer, TheCrow.
I write my theme from zero, using Zen.
I can send you theme files on e-mail that you could reproduce an error.
Comment #6
TheCrow commentedProbably due to a double escape of 'title' field in the theme_links hook (template.php)
Comment #7
TheCrow commentedAfter examinate the trouble in darkkin's theme and solved it, i consider this issue closed
Comment #8
Kendall Totten commented"Posted by TheCrow on September 26, 2010 at 7:08am
Probably due to a double escape of 'title' field in the theme_links hook (template.php)"
What do you mean? I am having the same problem... how do I fix this? Thanks.
Comment #9
TheCrow commentedInto the file template.php of your theme you should have a function like phptemplate_links() or themename_links() that overwrite the standard theme function and introduce a row which escape the title of link through check_plain() function:
in the theme i was inspecting i found
and i replaced it with:
Comment #10
mattwmc commentedNevermind! Had to configure in block setting.
Comment #11
TheCrow commentedhi matt your template.php seem ok, i tried your theme and all work, maybe some other module reimplement this function or alter the normal links render...
Comment #12
mattwmc commentedThanks for the quick reply.
I got it to work! Great mod!
Comment #13
TheCrow commentedComment #15
jenlamptonThis problem is not related to theme_links() since it also exists in the service links blocks.
I have enabled the "Service links block for not-node pages" (though I think you meant non-node pages) and the images will not appear when the style is "Image" or "Image and text". The text appears correctly when the sytle is "Image and text" or "Text".
The problem is in your service_links_expand_path() function. For some reason it is returning /sites/all/modules/service_links when that's not where I have my module.
Here's the problem: in service_links.admin.inc on line 140 you are setting the default value of "Alternative icon's folder" when there should only be a value saved to the db when the service_links icons are not being used.
Comment #16
jenlamptonHere's a patch for the dev branch, but the same fix works on 2.0.
This will include the "current" location of images in the description text, just in case people are curious, but will not save anything to the db unless that path needs to be overridden.
Comment #17
TheCrow commentedHi jenlampton,
I confirm that the issue raised here is fixed in the theme function (watch the image attached in the original post and u will understand that what u say is totally out-context)
I also have enabled the "only image" style for not nodes block and it work perfect with the latest dev version.
service_links_expand_path() has been changed in one of the latest commits, try it again and open an issue if u are sure that there is a bug!