I notice there are error messages like the following:

The specified file %file could not be copied, because the destination %destination is invalid. This is often caused by improper use of file_unmanaged_copy() or a missing stream wrapper.

As far as I recall, there should not be any comma between copied, and because.

CommentFileSizeAuthor
#8 dependent-clause-errors-806974-8.patch21.13 KBdrupal_was_my_past
#2 806974_punctuaction_errors.patch8.57 KBavpaderno

Comments

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Component: other » user interface text
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
StatusFileSize
new 806974_punctuaction_errors.patch8.57 KB
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Priority: Minor » Normal
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Active » Needs review

I forgot to set the correct status. I apologize for that.

dries’s picture

dries commented

I would also be inclined to drop those commas but it would be good to get someone else's feedback too.

dhthwy’s picture

dhthwy commented

I'm not an English major, but I doubt the commas are needed in those sentences. I normally don't see commas used before 'because' unless the sentence is long and complex.

yoroy’s picture

yoroy commented
Version: 7.x-dev » 8.x-dev
Priority: Normal » Minor
Status: Needs review » Needs work

Yup, remove the commas. Seems minor though. Needs a patch using Git now.

drupal_was_my_past’s picture

drupal_was_my_past commented
Status: Needs work » Needs review
StatusFileSize
new dependent-clause-errors-806974-8.patch21.13 KB

Re-rolling patch from #2 with some additions. Commas are used in a number of situations, but they are generally only used to separate independent clauses that are joined by and, but, for, or, nor, so, yet. It's pretty uncommon to see them used the way they currently are in core to separate a dependent clause joined by because or due to. I didn't catch all of them, but I got several more in this patch.

bleen’s picture

bleen commented

I didn't check that the patch in #8 actually applies, but the grammatical corrections all look good. As long as it applies I would say that this is definitely RTBC.

That is a grammatical point up with which I will not put. - Churchill

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Reviewed & tested by the community

Patch applies, only comment changes, all look fine.

catch’s picture

catch
he/him
Primary language English
commented

This touches a lot of files so I'm going to hold of committing until we're back under the major bug threshold again.

Patch looks fine though although I only scanned over the changes for now.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

I reviewed this patch and all fixed are correct.

Furthermore, we're back below our issue thresholds so I committed this patch to 8.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.