When I submit repeat events I get the following PHP warning:

warning: gmmktime() expects parameter 6 to be long, string given in /var/www/drupal-dev/modules/eventrepeat/eventrepeat.module on line 2153.

This is due to the statement $node->$prefix.'year' being interpreted incorrectly.

Instead of taking the value of $prefix.'year' and using it to look up a property in $node PHP looks for $node->$prefix and concatenates that with 'year' resulting in the string "year" being passed as the 6th parameter to gmmktime() (in my case).

This patch changed it to $node->$prefix_year. $prefix _year is already defined to be $prefix.'year' and is used in the rest of the function (this statement was probably just overlooked earlier).

CommentFileSizeAuthor
concat_prop_name.patch.txt829 bytesdavemicc

Comments

seanbfuller’s picture

Status: Needs review » Fixed

Committed to HEAD.

Anonymous’s picture

Status: Fixed » Closed (fixed)