Fatal error calling sys_get_temp_dir() in installer - pHP 5.2.0 and earlier

What version of PHP are you using? The minimum requirement used to be 5.2.0, but was recently changed to 5.2.1 (see #551658: Figure out what to do about new private/public file separation).

Drupal is supposed to tell you that PHP version requirement on the requirements page, but it looks like there is a bug where it calls the above function (which doesn't exist in 5.2.0) before it ever is able to display the requirements page.... oops :)

When installing with PHP 5.2.0 or earlier a PHP fatal error is encountered. This is because the requirements check is not performed before the installer attempts to call sys_get_temp_dir()

Marking as critical as users will encounter this error, not be able to install head, and not know how to resolve the problem.

simple fix.

BTW - here is a testing strategy that doesn't require actually installing an old php version. Set DRUPAL_MINIMUM_PHP to something large like 5.2.100, then replace the call to sys_get_temp_dir() with something like XXX(). Without the patch you'll see the error, after applying the patch you should see the notice that you have an old PHP version.

Applied patch and attempted to install system with php 5.2.0. The requirements check page is far more friendly than a PHP fatal error. However, it still seems silly that PHP 5.2.1 is the minimum requirement for Drupal 7, especially since this change occurred so late in the development cycle.

+1 for functionality, with reservations.

Three years since PHP 5.2.1 is out... we are good.

@chx

I agree that we are technically good on this issue. However, the number of years since php 5.2.1 has been released is arbitrary. What if it had been 2 years, or 1 year?

Then we would be much more cautious. About 2-2.5 years should be enough to be included in practically every Linux distribution by now.

This patch makes sense regardless of what the current PHP requirement is.

#551658: Figure out what to do about new private/public file separation may yet end up rolling back the requirements change but I think that should be handled there.

+++ modules/system/system.install
@@ -74,6 +74,8 @@ function system_requirements($phase) {
+    // If PHP is old, it's not safe to continue with requirements check.

Are we missing the word 'the'?

fixed comment.

#11: 807622.patch queued for re-testing.

back to RTBC

Committed to CVS HEAD. Thanks.