Use microformat for theme_comment_block()

Yes, technically <var> is a better choice. It's definitely one of those rarely used tags... I submitted the patch that got rid of the old <br/> tag and added the <span>, and at the time <var> didn't even come to mind.

It definitely needs a space before the tag though, whether it is changed or not, so it's not totally squished against the comment title (my fault, sorry), so I'm changing this to a bug report.

Sounds good to me. Thanks for the re-roll.

RTBC'ing 807744-comment-block-var-nbsp-d7.patch in #5.

My understanding of the var-tag is that it is used to indicate a variable or a parameter for an application. It does not sound appropriate to use in this context. At a minimum it requires some more research and discussion.

I had the same reaction initially. It's definitely not a popular tag, so I tried to find some actual implementations. Even though I didn't find any, I found a better definition and examples:

The var element represents a variable. This could be an actual variable in a mathematical expression or programming context, or it could just be a term used as a placeholder in prose.

Programming context example:
At the bottom of the search results screen, we have added "Next <var>n</var>" functionality to allow the user to view more than one screen of search results.

Mathematical and placeholder in prose examples:

<figure>
 <math>
  <mi>a</mi>
  <mo>=</mo>
  <msqrt>
   <msup><mi>b</mi><mn>2</mn></msup>
   <mi>+</mi>
   <msup><mi>c</mi><mn>2</mn></msup>
  </msqrt>
 </math>
 <figcaption>
  Using Pythagoras' theorem to solve for the hypotenuse <var>a</var> of a triangle with sides <var>b</var> and <var>c</var>
 </figcaption>
</figure>

<p>If there are <var>n</var> pipes leading to the ice cream factory then I expect at <em>least</em> <var>n</var> flavors of ice cream to be available for purchase!</p>

The definitions are still pretty vague, but it's not just for application variables and in this case, it seemed correct that the date is a variable because of the way it's formatted, but maybe I'm wrong? Maybe just because the date is variable doesn't mean it is a variable? I'm confused now.

Anyway, I'm sorry I jumped the gun here. I should have solicited more reviews before marking this RTBC. I am tagging "needs design review" in case anyone can provide some input.

The way I understand this, <var> is for symbols (either mathematical or literal). It doesn't seem like the proper choice here.

However, if we wrap this in a <abbr> and add the full ISO8601 timestamp, we could have a nice microformat here.

Good idea Damien :)

Hopefully I did this correctly.

Forgot about that. :)

Looks very good to me.

But why? I'm happy to add a microformat, but it feels like we're adding it just because we can. We can thinker more about this in D8?

@Dries There is no other reason, so waiting to do this in D8 sounds fine. However, we do have a bug here that needs to be fixed for D7. A space is needed before the opening span, otherwise the text is squished together. Here's a quick screenshot of the problem and patch that just adds the needed space.

Then we can switch this back to D8 with a more appropriate title.

Committed to CVS HEAD. Thanks.

Patch #16 accidentily lost D7 concat coding style...?

Thanks @andypost!

Ugh, I feel so bad. Sorry Dries! :(

Committed to HEAD.

I think was already committed, not sure why its in needs review state.