Problem:
If you try to move the mouse pointer above the site_name the 'title' of the anchor is empty.

Description:
In the template.php file the ninesixty_preprocess_page() function contains the 'title' was outside of the 'attributes' array, because behind the 'rel' item there was a closing round brackets.

Solution:
The attached patch handles this problem correctly.

CommentFileSizeAuthor
#7 ninesixty-807800.patch1.52 KBWebappz
#3 960_link.patch.txt1.27 KBWebappz
#1 960_link.patch1.27 KBWebappz

Comments

Webappz’s picture

Webappz commented
StatusFileSize
new 960_link.patch1.27 KB

Sorry, I post the patch.

Webappz’s picture

Webappz commented
Webappz’s picture

Webappz commented
StatusFileSize
new 960_link.patch.txt1.27 KB

Sorry for mistakes, but it is my first patch.

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented
Status: Needs review » Reviewed & tested by the community

Looks good! Altough I do not like those long code lines and I prefer multi line if's I do mark it as reviewed.

maybe it's a good idea to make some code improvements directly?

Webappz’s picture

Webappz commented
Assigned: Webappz » Unassigned

@Nick_vh: I thanks to you to check and test my patch.
I agree with you, because I also do not like long code lines, but unfortunately the most themes use the long version.
If you create a subtheme which based on ninesixty - I also did it - you can modify it easily.

nick_vh’s picture

nick_vh
he/him
Location Ghent
commented

It's not because most of them do that you are not allowed to not do that ;-)
http://drupal.org/coding-standards tells somewhere that 80 characters are the maximum for lines including arrays so go ahead and submit that altered patch!

Webappz’s picture

Webappz commented
StatusFileSize
new ninesixty-807800.patch1.52 KB

@Nick_vh I thanks to you your advice.
I modified the code and I hope it will be good. :)

dvessel’s picture

dvessel commented

Thanks for the patch!

Unfortunately, I screwed up with managing the CVS 1.x branch and it's something I can't get into now but I'll get this fix in. I thought I could get in a 1.5 version with some hefty updates but I didn't branch for it. Now 1.x is a mess. Hah, I'll get it straightened out.

Webappz’s picture

Webappz commented

I'm happy to help with my patch and I'm waiting for the new release. :)